tests: Define and use some abbreviations No functional change. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Use feed_files for setup scripts To make setup scripting more similar to test scripting. Also permits use of countries other than POGO there, but that isn't necessary right now. Setup scripts renamed from init_script to setup-POGO. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Rename final xdump files to final.xdump The other test output files have fixed names, and having just one with a name that varies with the test name complicates things with no gain. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Disable GODNEWS by default Only actofgod-test wants it. Enable it there. The others either don't want it (fire-test), or don't care. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Move "not expected to work" warning into test-common.sh Warn the first time a server is started. Incorrect for info-test with POSIX threads, so suppress the warning there. Improve the warning message a bit while we're at it. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Trim trailing white space from source code Normally, git's pre-commit hook protects us from them. However, when expected test output contains trailing white space, we have to bypass commit hooks. Unwanted space can then slip in if you don't pay attention. I obviously didn't; clean up. The previous commit should reduce the need for such hook suppression. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: New helper function feed_input, for comment support feed_input drops lines starting with a bar character '|', so they can serve as comments. Syntax chosen because such lines shouldn't be needed in tests. In particular, the server already ignores such lines when it reads commands, because they get parsed as empty command with a pipeline, and empty commands get ignored, regardless of redirections. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Factor out begin_tests(), end_tests() Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Drop smoke.out, actofgod.out Uninteresting since commit 9ca3fa9, v4.3.32. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests/actofgod: New, disabled for now because it oopses This is a fairly comprehensive test of the deity commands to edit game state: edit, setresource, setsector, give, swapsector. The test makes edit screw up game state, triggering oopses. The server refuses to start without -F then, and empdump -x warns "export has errors, not importable as is". Until these bugs are fixed, skip this test in "make check". Signed-off-by: Markus Armbruster <armbru@pond.sub.org>