navigate: Require all ships to start in the same sector The capability to navigate ships spread over several sectors is obscure and rarely useful. Accidental use is probably more frequent than intentional use. Issues: * Interactive prompts show only the flagship's position, and give no clue that some ships are actually elsewhere. * Path finding is supported only when all navigating ships are in the same sector. * Interdiction becomes rather complex. For each movement, every sector entered is interdicted independently. This means the same fort, ship, land unit or plane can interdict multiple times. Interdiction order depends on the order the code examines ships. which the player can control. This is all pretty much undocumented. * Complicates the code and its maintenance. Multiplies the number of test cases needed to cover navigate. I feel we're better off without this feature. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
march: Require all land units to start in the same sector The capability to march land units spread over several sectors is obscure and rarely useful. Accidental use is probably more frequent than intentional use. Issues: * Interactive prompts show only the leader's position, and give no clue that some land units are actually elsewhere. * Path finding is supported only when all marching land units are in the same sector. * In each step, the bmap is updated for the leader's radar. The bmap is not updated around other marching land units. Already odd when all units are in the leader's sector, and odder still when some are elsewhere. * Interdiction becomes rather complex. For each movement, every sector entered is interdicted independently. This means the same ship, land unit or plane can interdict multiple times. Interdiction order depends on the order the code examines land units. which the player can control. This is all pretty much undocumented. * Complicates the code and its maintenance. Multiplies the number of test cases needed to cover march. I feel we're better off without this feature. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests/navi-march: New; exercises navigate and march command Does not cover scattered navigate and march, RAILWAYS 0, enemy action while sitting at the prompt, and interdiction. The test exposes bugs. They're marked "BUG:" in the test input. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>