/*
* Empire - A multi-player, client/server Internet based war game.
- * Copyright (C) 1986-2012, Dave Pare, Jeff Bailey, Thomas Ruschak,
+ * Copyright (C) 1986-2021, Dave Pare, Jeff Bailey, Thomas Ruschak,
* Ken Stevens, Steve McClure, Markus Armbruster
*
* Empire is free software: you can redistribute it and/or modify
* Dave Pare, 1986
* Thomas Ruschak, 1992
* Steve McClure, 2000
- * Markus Armbruster, 2004-2011
+ * Markus Armbruster, 2004-2017
*/
#include <config.h>
#include "plague.h"
#include "ship.h"
+static int can_tend_to(struct shpstr *, int, struct shpstr *, int);
+static int tend_comm_to(struct shpstr *, struct ichrstr *, int,
+ struct shpstr *);
static void expose_ship(struct shpstr *s1, struct shpstr *s2);
-static int tend_land(struct shpstr *tenderp, char *units);
+static int tend_land(struct shpstr *tenderp, int, char *units);
int
-tend(void)
+c_tend(void)
{
struct nstr_item targets;
struct nstr_item tenders;
struct mchrstr *vbase;
int amt;
int retval;
- int ontender;
- int ontarget;
int maxtender;
- int maxtarget;
int transfer;
int total;
int type;
return RET_SYN;
while (nxtitem(&tenders, &tender)) {
- if (!player->owner)
+ if (!player->owner || !tender.shp_own) {
+ if (tenders.sel == NS_LIST)
+ pr("You don't own ship #%d!\n", tender.shp_uid);
continue;
+ }
if (type == EF_LAND) {
sprintf(prompt, "Land unit(s) to tend from %s? ",
prship(&tender));
continue;
if (!check_ship_ok(&tender))
return RET_SYN;
- if (0 != (retval = tend_land(&tender, p)))
+ retval = tend_land(&tender, tenders.sel == NS_LIST, p);
+ if (retval)
return retval;
continue;
}
pr("Amount must be non-zero!\n");
return RET_SYN;
}
- ontender = tender.shp_item[ip->i_uid];
- if (ontender == 0 && amt > 0) {
+ if (!tender.shp_item[ip->i_uid] && amt > 0) {
pr("No %s on %s\n", ip->i_name, prship(&tender));
- return RET_FAIL;
+ continue;
}
vbase = &mchr[(int)tender.shp_type];
maxtender = vbase->m_item[ip->i_uid];
if (maxtender == 0) {
- pr("A %s cannot hold any %s\n",
- mchr[(int)tender.shp_type].m_name, ip->i_name);
- break;
+ pr("%s cannot hold any %s\n", prship(&tender), ip->i_name);
+ continue;
}
if (!snxtitem(&targets, EF_SHIP,
player->argp[4], "Ships to be tended? "))
return RET_SYN;
total = 0;
while (nxtitem(&targets, &target)) {
- if (!player->owner
- && relations_with(target.shp_own, player->cnum) < FRIENDLY)
- continue;
- if (target.shp_uid == tender.shp_uid)
- continue;
- if (tender.shp_x != target.shp_x ||
- tender.shp_y != target.shp_y)
- continue;
- ontarget = target.shp_item[ip->i_uid];
- if (ontarget == 0 && amt < 0) {
- pr("No %s on %s\n", ip->i_name, prship(&target));
- continue;
- }
- vbase = &mchr[(int)target.shp_type];
- maxtarget = vbase->m_item[ip->i_uid];
- if (amt < 0) {
- if (!player->owner)
- amt = 0;
-
- /* take from target and give to tender */
- transfer = MIN(ontarget, -amt);
- transfer = MIN(maxtender - ontender, transfer);
- if (transfer == 0)
+ if (amt > 0) {
+ if (!can_tend_to(&tender, tenders.sel == NS_LIST,
+ &target, targets.sel == NS_LIST))
continue;
- target.shp_item[ip->i_uid] = ontarget - transfer;
- ontender += transfer;
- total += transfer;
+ transfer = tend_comm_to(&tender, ip, amt, &target);
} else {
- /* give to target from tender */
- transfer = MIN(ontender, amt);
- transfer = MIN(transfer, maxtarget - ontarget);
- if (transfer == 0)
+ if (!player->owner) {
+ if (targets.sel == NS_LIST)
+ pr("You don't own ship #%d!\n", target.shp_uid);
continue;
- target.shp_item[ip->i_uid] = ontarget + transfer;
- ontender -= transfer;
- total += transfer;
- if (transfer && target.shp_own != player->cnum) {
- wu(0, target.shp_own, "%s tended %d %s to %s\n",
- cname(player->cnum), total, ip->i_name,
- prship(&target));
}
+ if (!can_tend_to(&target, targets.sel == NS_LIST,
+ &tender, tenders.sel == NS_LIST))
+ continue;
+ transfer = tend_comm_to(&target, ip, -amt, &tender);
}
+ if (!transfer)
+ continue;
+ total += transfer;
expose_ship(&tender, &target);
putship(target.shp_uid, &target);
- if (amt > 0 && ontender == 0) {
+ if (amt > 0 && !tender.shp_item[ip->i_uid]) {
pr("%s out of %s\n", prship(&tender), ip->i_name);
break;
}
+ if (amt < 0 && tender.shp_item[ip->i_uid] == maxtender)
+ break;
}
pr("%d total %s transferred %s %s\n",
total, ip->i_name, (amt > 0) ? "off of" : "to",
prship(&tender));
- tender.shp_item[ip->i_uid] = ontender;
tender.shp_mission = 0;
putship(tender.shp_uid, &tender);
}
return RET_OK;
}
+static int
+can_tend_to(struct shpstr *from, int noisy_from,
+ struct shpstr *to, int noisy_to)
+{
+ /*
+ * Careful: error messages must not disclose anything on foreign
+ * @to the player doesn't already know, or could trivially learn.
+ */
+ if (!to->shp_own) {
+ if (noisy_to)
+ pr("You don't own ship #%d!\n", to->shp_uid);
+ return 0;
+ }
+ if (from->shp_uid == to->shp_uid) {
+ if (noisy_from && noisy_to)
+ pr("%s won't tend to itself\n", prship(from));
+ return 0;
+ }
+ if (from->shp_x != to->shp_x || from->shp_y != to->shp_y) {
+ if (noisy_from && noisy_to) {
+ /* Don't disclose foreign @to exists elsewhere */
+ if (player->god || to->shp_own == player->cnum)
+ pr("%s is not in the same sector as %s\n",
+ prship(to), prship(from));
+ else
+ pr("You don't own ship #%d!\n", to->shp_uid);
+ }
+ return 0;
+ }
+ if (!player->god && to->shp_own != player->cnum
+ && relations_with(to->shp_own, player->cnum) < FRIENDLY) {
+ if (noisy_to) {
+ /*
+ * Don't disclose unfriendly @to exists here unless
+ * lookout from @from would see it.
+ */
+ if ((mchr[from->shp_type].m_flags & M_SUB)
+ || (mchr[to->shp_type].m_flags & M_SUB))
+ pr("You don't own ship #%d!\n", from->shp_uid);
+ else
+ pr("You are not on friendly terms with"
+ " the owner of ship #%d!\n",
+ to->shp_uid);
+ }
+ return 0;
+ }
+ return 1;
+}
+
+static int
+tend_comm_to(struct shpstr *from, struct ichrstr *ip, int amt,
+ struct shpstr *to)
+{
+ int can_give = from->shp_item[ip->i_uid];
+ int to_max = mchr[to->shp_type].m_item[ip->i_uid];
+ int can_take = to_max - to->shp_item[ip->i_uid];
+ int transfer;
+
+ if (!to_max) {
+ pr("%s cannot hold any %s\n", prship(to), ip->i_name);
+ return 0;
+ }
+ if (ip->i_uid == I_CIVIL && from->shp_own != to->shp_own) {
+ pr("%s civilians refuse to board %s!\n",
+ from->shp_own == player->cnum ? "Your" : "Foreign",
+ prship(to));
+ return 0;
+ }
+ if (!can_give) {
+ pr("No %s on %s\n", ip->i_name, prship(from));
+ return 0;
+ }
+ if (!can_take) {
+ pr("%s can't hold more %s\n", prship(to), ip->i_name);
+ return 0;
+ }
+
+ transfer = MIN(can_give, amt);
+ transfer = MIN(can_take, transfer);
+ from->shp_item[ip->i_uid] -= transfer;
+ to->shp_item[ip->i_uid] += transfer;
+ if (to->shp_own != player->cnum) {
+ wu(0, to->shp_own, "%s tended %d %s to %s\n",
+ cname(player->cnum), transfer, ip->i_name, prship(to));
+ }
+
+ return transfer;
+}
+
static void
expose_ship(struct shpstr *s1, struct shpstr *s2)
{
}
static int
-tend_land(struct shpstr *tenderp, char *units)
+tend_land(struct shpstr *tenderp, int noisy, char *units)
{
struct nstr_item lni;
struct nstr_item targets;
return RET_SYN;
while (nxtitem(&lni, &land)) {
- if (!player->owner)
+ if (!player->owner || !land.lnd_own) {
+ if (lni.sel == NS_LIST)
+ pr("You don't own land unit #%d!\n", land.lnd_uid);
continue;
+ }
if (land.lnd_ship != tenderp->shp_uid) {
- pr("%s is not on %s!\n", prland(&land), prship(tenderp));
+ if (lni.sel == NS_LIST)
+ pr("%s is not on %s!\n", prland(&land), prship(tenderp));
continue;
}
if (!(lchr[(int)land.lnd_type].l_flags & L_ASSAULT)) {
if (!check_ship_ok(tenderp) || !check_land_ok(&land))
return RET_SYN;
while (nxtitem(&targets, &target)) {
- if (!player->owner
- && relations_with(target.shp_own, player->cnum) < FRIENDLY)
- continue;
- if (target.shp_uid == tenderp->shp_uid)
- continue;
- if (tenderp->shp_x != target.shp_x ||
- tenderp->shp_y != target.shp_y)
+ if (!can_tend_to(tenderp, noisy,
+ &target, targets.sel == NS_LIST))
continue;
/* Fit unit on ship */
expose_ship(tenderp, &target);
putship(target.shp_uid, &target);
putship(tenderp->shp_uid, tenderp);
+ break;
}
}
return 0;