/*
* Empire - A multi-player, client/server Internet based war game.
- * Copyright (C) 1986-2007, Dave Pare, Jeff Bailey, Thomas Ruschak,
+ * Copyright (C) 1986-2008, Dave Pare, Jeff Bailey, Thomas Ruschak,
* Ken Stevens, Steve McClure
*
* This program is free software; you can redistribute it and/or modify
* ---
*
* dispatch.c: Actually execute the command given
- *
+ *
* Known contributors to this file:
* Dave Pare, 1994
* Steve McClure, 1998
+ * Markus Armbruster, 2007
*/
#include <config.h>
struct cmndstr *command;
int cmd;
- cmd = comtch(player->argp[0], player_coms, player->ncomstat);
+ cmd = comtch(player->argp[0], player_coms, player->nstat);
if (cmd < 0) {
if (cmd == M_NOTUNIQUE)
pr("Command \"%s\" is ambiguous -- ", player->argp[0]);
else if (cmd == M_IGNORE)
return 0;
- else {
- pr("\"%s\" is not a legal command ", player->argp[0]);
- if (player->nstat != player->ncomstat)
- pr("now ");
- pr("\n");
- }
+ else
+ pr("\"%s\" is not a legal command\n", player->argp[0]);
return -1;
}
command = &player_coms[cmd];
pr("Command not implemented\n");
return 0;
}
+ /*
+ * Rwlocks can hand out read locks while a write lock is wanted.
+ * Unfair to writers, but possible. This lets commands run with
+ * !player->aborted, which can then block on input and thus delay
+ * the update indefinitely. We could avoid that by setting
+ * player->aborted here, but spinning until the update is done is
+ * nicer to players.
+ */
+ while (play_wrlock_wanted)
+ empth_yield();
+ player->command = command;
empth_rwlock_rdlock(play_lock);
if (redir) {
prredir(redir);
uprnf(buf);
pr("\n");
}
- player->command = command;
switch (command->c_addr()) {
case RET_OK:
player->btused += command->c_cost;
pr("Usage: %s\n", command->c_form);
break;
default:
- logerror("%s: returned bad value", command->c_form);
+ CANT_REACH();
break;
}
empth_rwlock_unlock(play_lock);
- player->command = 0;
+ player->command = NULL;
return 0;
}