Clean up dead stores

[empserver] / src / lib / update / nav_ship.c

diff --git a/src/lib/update/nav_ship.c b/src/lib/update/nav_ship.c
index e1fe2b0b25f1b9ad3c3998c2739c716e021929a6..c2c2605b3bd54e33ecc62d68691fca0bb880a1c2 100644 (file)
--- a/src/lib/update/nav_ship.c
+++ b/src/lib/update/nav_ship.c
@@ -1,6 +1,6 @@
 /*
  *  Empire - A multi-player, client/server Internet based war game.
- *  Copyright (C) 1986-2008, Dave Pare, Jeff Bailey, Thomas Ruschak,
+ *  Copyright (C) 1986-2010, Dave Pare, Jeff Bailey, Thomas Ruschak,
  *                           Ken Stevens, Steve McClure
  *
  *  This program is free software; you can redistribute it and/or modify
@@ -26,7 +26,7 @@
  *  ---
  *
  *  nav_ship.c: Navigate ships and such
- * 
+ *
  *  Known contributors to this file:
  *     Chad Zabel, 1994
  *     Ken Stevens, 1995
@@ -53,24 +53,23 @@ scuttle_it(struct shpstr *sp)
           sp->shp_x, sp->shp_y, sp->shp_uid);
        return;
     }
-    if (sectp->sct_type != SCT_HARBR || sectp->sct_effic < 2) {
-       wu(0, sp->shp_own,
-          "%s is not in a harbor at least 2%% eff!  Not scuttling.\n",
-          prship(sp));
-       return;
-    }
     if (opt_TRADESHIPS) {
        if (!(mchr[(int)sp->shp_type].m_flags & M_TRADE)) {
            wu(0, sp->shp_own, "You can only autoscuttle trade ships!\n");
            return;
        }
     }
+    if (!scuttle_tradeship(sp, 0)) {
+       wu(0, sp->shp_own,
+          "%s doesn't pay here!  Not scuttled.\n", prship(sp));
+       return;
+    }
     wu(0, sp->shp_own, "Scuttling %s in sector %s\n",
        prship(sp), xyas(sp->shp_x, sp->shp_y, sp->shp_own));
-    if (opt_TRADESHIPS) {
-       scuttle_tradeship(sp, 0);
-    }
-    scuttle_ship(sp);
+    if (sectp->sct_own == sp->shp_own)
+       unit_drop_cargo((struct empobj *)sp, sectp->sct_own);
+    sp->shp_effic = 0;
+    putship(sp->shp_uid, sp);
 }
 
 static void
@@ -229,7 +228,7 @@ nav_load_ship_at_sea(struct shpstr *sp)
 }
 
 /* new autonav code.
- * 
+ *
  * 1. Try and move to the next sector/harbor given by the player.
  * 2. Once we reach a harbor try and load all cargo holds for that ship.
  * 3. If the ship reaches its max levels set by the player try to use
@@ -238,8 +237,8 @@ nav_load_ship_at_sea(struct shpstr *sp)
  * the ship gets sunk (forts,ect..), the ship hits a mine.
  *
  * Questions, bugs (fixes) , or new ideas should be directed at
- * Chad Zabel.  
- * 6-1-94   
+ * Chad Zabel.
+ * 6-1-94
  * Modified to use shp_nav by Ken Stevens 1995
  */
 int
@@ -269,11 +268,10 @@ nav_ship(struct shpstr *sp)
     mlp = malloc(sizeof(struct ulist));
     mlp->chrp = (struct empobj_chr *)(mchr + sp->shp_type);
     mlp->unit.ship = *sp;
+    ef_mark_fresh(EF_SHIP, &mlp->unit.ship);
     mlp->mobil = sp->shp_mobil;
     emp_insque(&mlp->queue, &ship_list);
 
-    quit = 1;                  /* setup loop, we want to check it 1 time. */
-
     do {
        if ((sp->shp_mobil > 0) && (!(sp->shp_autonav & AN_LOADING)) &&
            (!(sp->shp_autonav & AN_STANDBY))) {
@@ -285,7 +283,7 @@ nav_ship(struct shpstr *sp)
            cp = BestShipPath(buf, sp->shp_x, sp->shp_y,
                              sp->shp_destx[0], sp->shp_desty[0],
                              sp->shp_own);
-           if (cp == 0) {
+           if (!cp) {
                wu(0, cnum,
                   "%s bad path, ship put on standby\n", prship(sp));
                sp->shp_autonav |= AN_STANDBY;