]> git.pond.sub.org Git - empserver/commit - src/lib/commands/load.c
Fix relation checks in load, unload, lload, lunload
authorMarkus Armbruster <armbru@pond.sub.org>
Sun, 4 Jan 2009 09:49:17 +0000 (10:49 +0100)
committerMarkus Armbruster <armbru@pond.sub.org>
Tue, 6 Jan 2009 13:59:01 +0000 (14:59 +0100)
commitafb512fad76c9497c3e29e94bfc15a3e19f9a6e8
tree27899b8666150f9f1c058aa2d7f3e92333a12db4
parent1c547f9b42a9a2238538a3d0c3bce382c304ccc5
Fix relation checks in load, unload, lload, lunload

The check for ship owner's relations to the player was backward: it
checked the player's relations to the ship's owner instead.  Abusable:
you could load and unload any ship by declaring friendly to its owner.
Broken since Chainsaw let you load and unload friendly ships.

The check for land unit owner's relations to the player was similarly
backward, similarly abusable, and also broken since day one.

lload and lunload checked sector owner's relations to the land unit's
owner instead of to the player.  Harmless, because the two must be the
same to reach the check.
src/lib/commands/load.c