]> git.pond.sub.org Git - empserver/commit - src/lib/commands/offe.c
Get rid of RET_SYS, just use RET_FAIL
authorMarkus Armbruster <armbru@pond.sub.org>
Sun, 3 Aug 2008 15:34:00 +0000 (11:34 -0400)
committerMarkus Armbruster <armbru@pond.sub.org>
Sun, 3 Aug 2008 15:34:00 +0000 (11:34 -0400)
commit29aefc356f4b9ec709fd86a307ac3352fa3c20a1
tree00599b7e7367637e90f421035053431fe48bc359
parente803950463d4152c3849ea83b6b42d19a64e0841
Get rid of RET_SYS, just use RET_FAIL

RET_SYS was used for commands failing due to internal or environmental
errors, but not really systematically.  The difference to RET_FAIL is
how dispatch() treats them: RET_SYS got logged, and cost no BTUs.

More specific logging is possible at the point of failure than in
dispatch().  Make sure that's done for all failures that used to
return RET_SYS.

The change in BTU charging affects commands consider, offer, repay,
trade failing due to internal errors.  It also affects deity commands
reload and turn (irrelevant because deities get unlimited BTUs), and
commands apropos, info and motd (irrelevant because they cost no
BTUs).
include/misc.h
src/lib/commands/cons.c
src/lib/commands/info.c
src/lib/commands/offe.c
src/lib/commands/relo.c
src/lib/commands/repa.c
src/lib/commands/trad.c
src/lib/commands/turn.c
src/lib/player/dispatch.c
src/lib/player/player.c