]> git.pond.sub.org Git - empserver/commit
retreat: Fix stack smash in land unit group retreat
authorMarkus Armbruster <armbru@pond.sub.org>
Mon, 20 Jan 2014 19:28:17 +0000 (20:28 +0100)
committerMarkus Armbruster <armbru@pond.sub.org>
Sun, 16 Feb 2014 12:19:25 +0000 (13:19 +0100)
commit2cc0664e3e5a4f1c0a340def8333fe09345b0e7f
treec692d8a87058e347aa0a92e916905db9c0bbfaa9
parenta963b4e70330f9362111052ddf8236e1b376ac2b
retreat: Fix stack smash in land unit group retreat

retreat_land() reads ships instead of land units, overrunning local
variable land.  On lucky systems such as mine, this clobbers ni, and
triggers an oops.  On unlucky systems, it crashes.  On really unlucky
systems, it corrupts the land units file.

Broken since land unit retreat was added in Chainsaw 3.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
src/lib/subs/retreat.c
tests/retreat/01-retreat-1
tests/retreat/final.xdump
tests/retreat/journal.log
tests/retreat/server.log