Fix client redirection and execute for non-ASCII characters
authorMarkus Armbruster <armbru@pond.sub.org>
Sat, 2 Jul 2011 15:17:53 +0000 (17:17 +0200)
committerMarkus Armbruster <armbru@pond.sub.org>
Sat, 9 Jul 2011 13:16:21 +0000 (15:16 +0200)
commit36015e8c0e075b698eb69ea07d34bd6fe27da55e
tree6846a5ae28f25827b7a4e5f013a4b9ec61bbe3f8
parentafb45d933e3798825fdbd57297a4cddd1b420505
Fix client redirection and execute for non-ASCII characters

The client rejects unauthorized redirection and execute.  Its
authorized check always fails for arguments with non-ASCII characters.
The culprit is ring_search(): It compares plain char to unsigned char,
which breaks when char is signed.  Believed to be broken in commit
8b7d0b91, v4.3.11.

Note that non-ASCII characters only work in UTF-8 sessions.  In ASCII
sessions, the server replaces them, and the authorized check fails.
Works as designed.
src/client/ringbuf.c