projects / empserver / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9b92ac6) | patch
Fix uninitialized variable use in defending land unit retreat
authorMarkus Armbruster <armbru@pond.sub.org>
Mon, 5 Mar 2012 11:57:33 +0000 (12:57 +0100)
committerMarkus Armbruster <armbru@pond.sub.org>
Mon, 5 Mar 2012 11:57:52 +0000 (12:57 +0100)
commit68dc9b2936b9f8c6ee8fbf5555977986227225bd
tree822b7363c6dbc1bd893bc28b0fe8cd35c767d374tree | snapshot
parent9b92ac633d8efd8e8b52c9287193066bcefd303dcommit | diff
Fix uninitialized variable use in defending land unit retreat

lnd_take_casualty() uses uninitialized rsect to compute the mobility
cost of retreating a defending land unit.  This can charge incorrect
mobility, prevent retreat, or, if the stars align just right, crash
the server when sector_mcost() subscripts dchr[] with it.

Broken in commit 4e7c993a, v4.3.6.  Reported by Scott C. Zielinski.
src/lib/subs/lndsub.c diff | blob | history
Markus's Wolfpack Empire tree