Use feels_like_helping() in dosupport(), lnd_support()
authorMarkus Armbruster <armbru@pond.sub.org>
Mon, 31 Jan 2011 19:53:44 +0000 (20:53 +0100)
committerMarkus Armbruster <armbru@pond.sub.org>
Sun, 13 Feb 2011 15:06:22 +0000 (16:06 +0100)
commit89bc9c4d5b2cfda70494539c0af38ebe3bed50e2
tree534045d8cfec54beb38aff42d0f4034b660b3e42
parentc095ad285be9075f76c96645f763005d8f719a6f
Use feels_like_helping() in dosupport(), lnd_support()

feels_like_helping() case cn == foe is missing in the code it
replaces.  No difference in behavior, because:

* cn == foe && cn == friend can't happen.  Because you can't get into
  ground combat against yourself (assault, attack and paradrop don't
  let you), friend != foe for support.

* cn == foe && cn != friend behaves the same: no support.
  feels_like_helping() returns 0 because of the explicit case.  The
  replaced code doesn't support because cn can't be at war with
  itself.
src/lib/subs/lndsub.c
src/lib/subs/mission.c