]> git.pond.sub.org Git - empserver/commit
Remove columns lnd, pln from spy report to fix spy unit leak
authorMarkus Armbruster <armbru@pond.sub.org>
Sat, 14 Jun 2008 16:55:29 +0000 (18:55 +0200)
committerMarkus Armbruster <armbru@pond.sub.org>
Sat, 14 Jun 2008 16:55:29 +0000 (18:55 +0200)
commita233ecfea9221e90396755a7e989cf227e46ae99
treed8c7e37a7b930a9f02f79f551e256cd2d0a8c0e3
parentc658d1e08dda599d67f7a70fcea60b58a391a5c5
Remove columns lnd, pln from spy report to fix spy unit leak

The values in these columns were computed by count_sect_units() and
count_sect_planes(), which included land units and planes in the count
that aren't shown by prunits() and prplanes(), namely own and embarked
units.  Confusing.  Moreover, count_sect_planes() and prunits() rolled
dice separately for spy units.  This could leak the presence of spies
even when prunits() didn't show them.

All fixable, but not worth the trouble; just remove the counts.
include/land.h
include/prototypes.h
src/lib/commands/spy.c
src/lib/subs/lndsub.c
src/lib/subs/plnsub.c