accept: Drop outdated FIXME SO_KEEPALIVE

SO_KEEPALIVE isn't useless with long idle timeouts.  Before v4.3.30's
idle timeout changes, such long timeouts had serious drawbacks (easy
denial of service), but they're just fine since then.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>

diff --git a/src/lib/player/accept.c b/src/lib/player/accept.c
index ca06065450a060f92d90f221970e006e7ae97966..ba022c2144ff3e0595a67aa61f075c0390e6d678 100644 (file)
--- a/src/lib/player/accept.c
+++ b/src/lib/player/accept.c
@@ -201,7 +201,6 @@ player_accept(void *unused)
            logerror("new socket accept");
            continue;
        }
-       /* FIXME SO_KEEPALIVE is useless, player_kill_idle() strikes long before */
        (void)setsockopt(ns, SOL_SOCKET, SO_KEEPALIVE, &set, sizeof(set));
        np = player_new(ns);
        if (!np) {