(main): Fix checking of ef_open()'s value. Fixes program exit status

when files can't be opened.

(logerror): The version from libcommon.a does the right thing since
log.c rev. 1.17.  Use it, remove local version.

(log_last_commands): No longer referenced by library code, remove.

diff --git a/src/util/files.c b/src/util/files.c
index 10a3486f554850745e41d243820af8e1c0369fd7..04e866b4fbb5b2b7b41a36daca8dc40b9d239ec0 100644 (file)
--- a/src/util/files.c
+++ b/src/util/files.c
@@ -123,7 +123,7 @@ main(int argc, char *argv[])
            exit(1);
     }
     for (i = 0; i < EF_MAX; i++) {
-       if (ef_open(i, O_RDWR | O_CREAT | O_TRUNC, 0) < 0) {
+       if (!ef_open(i, O_RDWR | O_CREAT | O_TRUNC, 0)) {
            perror("ef_open");
            exit(1);
        }
@@ -200,18 +200,3 @@ file_sct_init(coord x, coord y, s_char *ptr)
     sp->sct_dist_x = x;
     sp->sct_dist_y = y;
 }
-
-void
-logerror(s_char *format, ...)
-{
-    va_list ap;
-
-    va_start(ap, format);
-    vfprintf(stderr, format, ap);
-    va_end(ap);
-}
-
-void
-log_last_commands(void)
-{
-}