We know player != other. Because we can have only one player in state
PS_PLAYING per country, and we know other->state == PS_PLAYING, it
follows that player->cnum != other->cnum. Thus, no functional change.
Adds another call to getnatp() hidden in relations_with(), though.
Keeping that optimized isn't worth it.
wto = getnatp(other->cnum);
if (CANT_HAPPEN(!wto))
continue;
- if (!player->god && getrel(wto, player->cnum) != ALLIED)
+ if (!player->god
+ && relations_with(other->cnum, player->cnum) != ALLIED)
continue;
}
if (!player->god && !(wto->nat_flags & NF_FLASH)) {