Make setrel() refuse to change relations to self

No current caller actually attempts that, but let's make it obvious.

diff --git a/src/lib/subs/rej.c b/src/lib/subs/rej.c
index 9663e7299998ed0af0fcbe8186246be52a01f70c..05a2a81452fe3adfe1da57d74d0cb71238e0bffc 100644 (file)
--- a/src/lib/subs/rej.c
+++ b/src/lib/subs/rej.c
@@ -60,6 +60,8 @@ setrel(natid us, natid them, int rel)
        rel = ALLIED;
     if (CANT_HAPPEN(!mynp || !themnp))
        return;
        rel = ALLIED;
     if (CANT_HAPPEN(!mynp || !themnp))
        return;

+    if (us == them)
+       return;

     oldrel = getrel(mynp, them);
     if (oldrel == rel)
        return;
     oldrel = getrel(mynp, them);
     if (oldrel == rel)
        return;