Really fix give not to wipe out concurrent updates

give() continues after check_sect_ok() fails.  Clobbers the updates
that made check_sect_ok() fail, triggering a seqno mismatch oops.

Commit b58c37e2 (v4.3.27) claimed to fix this, but actually only
suppressed the generation oops.

diff --git a/src/lib/commands/give.c b/src/lib/commands/give.c
index b8d4577bd8bace7e26c12263c7b3f07bc2fa3864..dfe1df77ea7bd40bedefcdd8c1ab2e819a06a09a 100644 (file)
--- a/src/lib/commands/give.c
+++ b/src/lib/commands/give.c
@@ -62,7 +62,8 @@ give(void)
            return RET_SYN;
        if ((amt = atoi(p)) == 0)
            return RET_SYN;
-       check_sect_ok(&sect);
+       if (!check_sect_ok(&sect))
+           return RET_FAIL;
        n = sect.sct_item[ip->i_uid];
        if (amt < 0 && -amt > n) {
            m = 0;