contact: Avoid unnecessary nation updates

Make setcont() update the nation only when it actually changes the
contact value.  For added benefit, map all non-zero values to one when
option LOSE_CONTACT is disabled.

This saves I/O, in particular xdump bandwidth.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>

diff --git a/src/lib/subs/rej.c b/src/lib/subs/rej.c
index de11e8171108282bf55eaef3f888e80b409ddb7f..bf8882d19d47afb507e0d256d328ed8a235a7efa 100644 (file)
--- a/src/lib/subs/rej.c
+++ b/src/lib/subs/rej.c
@@ -123,9 +123,12 @@ setcont(natid us, natid them, int contact)
     if (CANT_HAPPEN(contact > 255))
        contact = 255;
 
-    if (np->nat_contact[them] < contact)
+    if (!opt_LOSE_CONTACT)
+       contact = !!contact;
+    if (np->nat_contact[them] < contact) {
        np->nat_contact[them] = contact;
-    putnat(np);
+       putnat(np);
+    }
 }
 
 void