From: Markus Armbruster <armbru@pond.sub.org>
Date: Wed, 7 Apr 2010 21:35:25 +0000 (+0200)
Subject: Fix test for capability engineer in lnd_hit_mine()
X-Git-Tag: hvy-plastic-2.3^0
X-Git-Url: http://git.pond.sub.org/?p=empserver;a=commitdiff_plain;h=62b93e56e2e3c821b2c384cf201168ccd5059902;hp=b62025e82c70c6d67f13194db5daeaec070921a0

Fix test for capability engineer in lnd_hit_mine()

Bogus array index, unpredictable result, can crash the server.  Broken
in commit ef7ea893, v4.3.24.
(cherry picked from commit 7506039f1b31eeaddab436831d23fb50c2f9409b)
---

diff --git a/src/lib/subs/lndsub.c b/src/lib/subs/lndsub.c
index a19e53dc2..a5808e7ce 100644
--- a/src/lib/subs/lndsub.c
+++ b/src/lib/subs/lndsub.c
@@ -862,7 +862,7 @@ lnd_hit_mine(struct lndstr *lp)
     nreport(lp->lnd_own, N_LHIT_MINE, 0, 1);
 
     m = MINE_LDAMAGE();
-    if (lchr[lp->lnd_uid].l_flags & L_ENGINEER)
+    if (lchr[lp->lnd_type].l_flags & L_ENGINEER)
 	m /= 2;
 
     landdamage(lp, m);