From: Markus Armbruster <armbru@pond.sub.org>
Date: Thu, 24 Jan 2013 21:01:45 +0000 (+0100)
Subject: setsector: Clean up read beyond end of string
X-Git-Tag: v4.3.32~59
X-Git-Url: http://git.pond.sub.org/?p=empserver;a=commitdiff_plain;h=d4e9dccbccde51c83476c6600752b69974384957

setsector: Clean up read beyond end of string

setsector() reads the first two characters unconditionally.  Wrong if
the first character is NUL.  The second character read isn't actually
used then.  Screwed up in Chainsaw.

When getstarg() returns an empty string, it's always in the buffer
passed as third argument.  Thus, reading the second character is
actually safe.

Clean it up anyway.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
---

diff --git a/src/lib/commands/setsect.c b/src/lib/commands/setsect.c
index c1490ab30..afbff7a49 100644
--- a/src/lib/commands/setsect.c
+++ b/src/lib/commands/setsect.c
@@ -56,7 +56,7 @@ setsector(void)
     what = getstarg(player->argp[1],
 		    "Give what (iron, gold, oil, uranium, fertility, owner, eff., mob., work, avail., oldown, mines)? ",
 		    buf);
-    if (!what)
+    if (!what || !*what)
 	return RET_SYN;
     char0 = what[0];
     char1 = what[1];