]>
git.pond.sub.org Git - empserver/log
Markus Armbruster [Mon, 1 Mar 2004 14:17:58 +0000 (14:17 +0000)]
(player_new) [!RESOLVE_IPADDRESS]: Don't define unused local variable.
Markus Armbruster [Mon, 1 Mar 2004 14:16:31 +0000 (14:16 +0000)]
(sctcache, bestp) [!DO_EFF_MEM_CHECKING]: cache isn't used, don't
define it.
Markus Armbruster [Mon, 1 Mar 2004 14:14:39 +0000 (14:14 +0000)]
(draw_map): Fix test of player->command->c_flags. Broken code
happened to work because C_MOD is the only flag defined.
Markus Armbruster [Mon, 1 Mar 2004 14:10:11 +0000 (14:10 +0000)]
Remove duplicate macro definitions.
Markus Armbruster [Mon, 1 Mar 2004 14:07:10 +0000 (14:07 +0000)]
Break excessively long line.
Markus Armbruster [Mon, 1 Mar 2004 14:06:23 +0000 (14:06 +0000)]
(deity_build_land) [!START_UNITS]: Unused, don't define.
Markus Armbruster [Mon, 1 Mar 2004 14:03:29 +0000 (14:03 +0000)]
Clean up switch cases: proper fall through comments, no break after
return.
Markus Armbruster [Mon, 1 Mar 2004 13:56:07 +0000 (13:56 +0000)]
Don't cast void to void.
Markus Armbruster [Mon, 1 Mar 2004 13:48:45 +0000 (13:48 +0000)]
Remove some unused junk.
Markus Armbruster [Mon, 1 Mar 2004 13:41:10 +0000 (13:41 +0000)]
Remove RCS keyword comment, it's a nuisance.
Markus Armbruster [Mon, 1 Mar 2004 13:33:51 +0000 (13:33 +0000)]
(sccsid): Useless, as we don't use SCCS. Remove.
Markus Armbruster [Mon, 1 Mar 2004 13:32:06 +0000 (13:32 +0000)]
(CHE_MAX): Don't define twice, define once in a header.
(get_che_cnum, set_che_cnum, get_che_value, set_che_value): Remove
redundant definitions.
Markus Armbruster [Mon, 1 Mar 2004 13:26:39 +0000 (13:26 +0000)]
(execute): Fix botched test for empty argument.
Markus Armbruster [Mon, 1 Mar 2004 09:04:02 +0000 (09:04 +0000)]
(mult, player_coms): Command `mult' is disabled since 4.0.0 ('96), and
its code is obviously not in working order. Remove.
(minmult, maxmult, configkeys): Unused configuration parameters,
remove.
(tradedesc): Remove code related to mult that had no effect.
(multread, commread, commwrite, commamt, commset, multset, commprice):
Dangerous, because code bypasses ef_read() & friends, remove.
(diss): Commodity cleanup uses the above, remove. Command is disabled
and unlikely to work anyway.
Markus Armbruster [Mon, 1 Mar 2004 07:10:31 +0000 (07:10 +0000)]
(interix, INTERIXCFLAGS, INTERIXLFLAGS, INTERIXMASTER): New, from Ron
Koenderink.
Markus Armbruster [Mon, 1 Mar 2004 07:07:27 +0000 (07:07 +0000)]
(safe_getcwd): New. When getcwd() is known to be able to allocate its
buffer, just call that. Else wrap suitable allocation around it.
(main): Use it.
Markus Armbruster [Mon, 1 Mar 2004 06:58:03 +0000 (06:58 +0000)]
(ntinstall): Fix mkdir data.
Markus Armbruster [Sun, 29 Feb 2004 11:41:26 +0000 (11:41 +0000)]
Fix missing include.
Markus Armbruster [Sun, 29 Feb 2004 11:41:08 +0000 (11:41 +0000)]
inet_ntoa() is available on all machines that matter, and defining it
ourselves without adequate auto-configuration creates more problems
than it solves. In particular since we defined it with the wrong
type.
Markus Armbruster [Sun, 29 Feb 2004 11:35:38 +0000 (11:35 +0000)]
(rea): Don't use L_SET, it's ancient BSD history, just use SEEK_SET.
Markus Armbruster [Sat, 28 Feb 2004 19:11:24 +0000 (19:11 +0000)]
Fix the previous rev.
Markus Armbruster [Sat, 28 Feb 2004 18:06:11 +0000 (18:06 +0000)]
Indentation fixes; suspect indent-emp is to blame.
Markus Armbruster [Sat, 28 Feb 2004 17:50:55 +0000 (17:50 +0000)]
Markup changes: separate items more clearly. Don't use numeric fonts.
Markus Armbruster [Sat, 28 Feb 2004 17:32:30 +0000 (17:32 +0000)]
\" comments weren't recognized in column 0.
Markus Armbruster [Sat, 28 Feb 2004 16:23:56 +0000 (16:23 +0000)]
(commodity_ca): "xloc", "yloc", "xsell", "ysel" and "price" weren't
NSC_DEITY. Wrong, but commodity_ca[] is currently unused. Also
rename "xloc", "yloc" to "xsell", "ysell".
Markus Armbruster [Sat, 28 Feb 2004 15:31:21 +0000 (15:31 +0000)]
(trade_ca): "xloc" and "yloc" weren't NSC_DEITY. Wrong, but
trade_ca[] is currently unused.
Markus Armbruster [Sat, 28 Feb 2004 09:45:10 +0000 (09:45 +0000)]
Remove some unused stuff, mostly Empire 3 leftovers.
Markus Armbruster [Sat, 28 Feb 2004 08:49:39 +0000 (08:49 +0000)]
(NSC_OPMASK, NSC_ISNUM1, NSC_ISNUM2, nscstr, nstr_comp, nstr_exec):
Simplify encoding of struct ncstr member oper.
Markus Armbruster [Sat, 28 Feb 2004 08:40:53 +0000 (08:40 +0000)]
(NSC_ROUND): No effect, remove.
Markus Armbruster [Sat, 28 Feb 2004 08:29:21 +0000 (08:29 +0000)]
(sect_ca, genitem_ca, ship_ca, plane_ca, land_ca, nuke_ca, treaty_ca,
loan_ca, news_ca, lost_ca, commodity_ca, trade_ca, nat_ca, map_ca):
NSC_OFF was lost during Empire3, rendering the codes confusing and
harder to use. Tack it back on.
(encode, code_char): No need to fool around with NSC_OFF anymore.
Markus Armbruster [Sat, 28 Feb 2004 07:19:31 +0000 (07:19 +0000)]
Delete dead code. No functional changes. Should have been committed
yesterday's along with nsc.h rev. 1.7.
Markus Armbruster [Sat, 28 Feb 2004 06:40:48 +0000 (06:40 +0000)]
These files were split a long time ago, for technical reasons which
since vanished (linking into different programs). Undo the split,
because the stuff really belongs together.
Markus Armbruster [Fri, 27 Feb 2004 21:55:50 +0000 (21:55 +0000)]
(setsector): Fix misleading prompt.
Markus Armbruster [Fri, 27 Feb 2004 20:13:28 +0000 (20:13 +0000)]
Delete dead code, fix indentation, spelling, obvious warning
avoidance, doc fixes. No functional changes.
Markus Armbruster [Fri, 27 Feb 2004 19:53:02 +0000 (19:53 +0000)]
(sct_typematch): New. Use it instead of typematch() where
appropriate.
(typematch): Prefer exact match to partial match. Use plain char
instead of s_char.
Markus Armbruster [Fri, 27 Feb 2004 19:38:38 +0000 (19:38 +0000)]
(stmtch, mineq): Document. Move declaration from prototypes.h to
match.h. Use plain char instead of s_char. The code has several
thousand type errors due to s_char vs plain char; s_char must go.
(stmtch): Rewrite for clarity.
Markus Armbruster [Thu, 26 Feb 2004 09:26:29 +0000 (09:26 +0000)]
(html): Expand tabs in all.html; they can confuse browsers.
Markus Armbruster [Thu, 26 Feb 2004 09:25:08 +0000 (09:25 +0000)]
Document yesterday's changes that closed #803753.
Don't re-explain the map in bmap commands.
Markus Armbruster [Wed, 25 Feb 2004 20:18:18 +0000 (20:18 +0000)]
Close #803753:
(map_char): New.
(draw_map): Use it. Wilderness and plains owned by other players are
now displayed as '?'.
(radmap2): Display wilderness and plains as '?'.
(satmap): Call satdisp() for all sectors owned by other players.
Markus Armbruster [Tue, 24 Feb 2004 20:54:58 +0000 (20:54 +0000)]
Spelling fix. Closes #901174.
Markus Armbruster [Tue, 24 Feb 2004 20:35:19 +0000 (20:35 +0000)]
(GCCWARNFLAGS): New.
(OSXCFLAGS, FREEBSDCFLAGS, LINUXCFLAGS, LINUXPTHCFLAGS): Use it.
Markus Armbruster [Tue, 24 Feb 2004 18:35:26 +0000 (18:35 +0000)]
(login_coms): Fix forward declaration (was a definition).
Markus Armbruster [Tue, 24 Feb 2004 18:34:25 +0000 (18:34 +0000)]
(fnlist): Move from misc.h to fnlist.h, where it belongs and has
complete type.
Markus Armbruster [Tue, 24 Feb 2004 18:26:34 +0000 (18:26 +0000)]
Remove junk at end of #endif.
Markus Armbruster [Tue, 24 Feb 2004 18:19:57 +0000 (18:19 +0000)]
(ef_ensure_space): New.
(edit): Use it to to fix copying to virgin unit slot. Closes #896475.
From Ron Koenderink.
Markus Armbruster [Sun, 22 Feb 2004 07:27:08 +0000 (07:27 +0000)]
(main, intr, handleintr, termio): Do the right thing for Windows so ^C
aborts to the current command, as it should. From Ron Koenderink.
Markus Armbruster [Sat, 21 Feb 2004 10:18:18 +0000 (10:18 +0000)]
(parse): Trailing whitespace was interpreted as an another (empty)
argument. Ignore it.
Markus Armbruster [Sat, 21 Feb 2004 06:58:25 +0000 (06:58 +0000)]
Fix the previous rev. so it compiles with strict compilers.
Markus Armbruster [Fri, 20 Feb 2004 20:45:18 +0000 (20:45 +0000)]
Don't declare things in more than one place. Move some declarations
between headers. Code is now fully prototyped and compiles cleanly
with gcc -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs
-Wredundant-decls. Closes #723788.
Markus Armbruster [Fri, 20 Feb 2004 20:34:43 +0000 (20:34 +0000)]
deity.h is redundant, remove it.
Markus Armbruster [Fri, 20 Feb 2004 20:14:53 +0000 (20:14 +0000)]
The (unused) parameter of thread entry points is named `argv', but the
argument is actually the value of global variable `player'. Rename to
`unused'.
Markus Armbruster [Fri, 20 Feb 2004 20:14:53 +0000 (20:14 +0000)]
Update for 4.2.14.
Markus Armbruster [Fri, 20 Feb 2004 19:24:43 +0000 (19:24 +0000)]
Fix the previous rev.
Markus Armbruster [Fri, 20 Feb 2004 11:17:32 +0000 (11:17 +0000)]
Portability fix: don't declare library function, include appropriate
header.
Markus Armbruster [Fri, 20 Feb 2004 10:51:03 +0000 (10:51 +0000)]
Add some missing declarations to headers. Remove some redundant
declarations elsewhere. Change linkage of some functions to static.
Markus Armbruster [Fri, 20 Feb 2004 08:22:28 +0000 (08:22 +0000)]
Declare tags.c variables in tags.h. Declare stuff with external
linkage that is not in any other header in misc.h. Remove some
redundant declarations elsewhere.
(prompt, doredir, dopipe, doexecute, output, screen, parsedelay):
Static linkage.
Markus Armbruster [Thu, 19 Feb 2004 21:15:16 +0000 (21:15 +0000)]
(loginit, main): Pass log file basename as parameter.
(logerror): Require prior call of loginit().
(empth_exit) [_EMPTH_WIN32]: Don't print the log file name here, it's
not modular.
(program, getlogfile): Unused, remove.
Markus Armbruster [Thu, 19 Feb 2004 21:10:25 +0000 (21:10 +0000)]
Fix the previous rev.
Markus Armbruster [Thu, 19 Feb 2004 21:03:57 +0000 (21:03 +0000)]
(cons_choose): Clean up somewhat dirty use of union pointers that's
not quite blessed by the standard and prone to trigger compiler
warnings.
Markus Armbruster [Thu, 19 Feb 2004 20:38:02 +0000 (20:38 +0000)]
(player_coms): Declaration in com.h was misspelled. Remove redundant
declarations elsewhere.
Markus Armbruster [Thu, 19 Feb 2004 20:30:22 +0000 (20:30 +0000)]
Remove some superflous declarations.
Markus Armbruster [Thu, 19 Feb 2004 19:59:45 +0000 (19:59 +0000)]
(bitinit2): Move from common/maps.c to getbit.c, external linkage.
(bitmap0, bitmap1, bitmap2, bitmap3, bitmap4, bitmaps): Static
linkage.
Markus Armbruster [Thu, 19 Feb 2004 19:14:29 +0000 (19:14 +0000)]
(effadv_list, effadv, rejects, rejectname, telnames, rea, numnames,
tennames, numstr): Replace by static local variables in their only
user.
(relates): Move from global/misc.c to common/nat.c.
(att_mode): Move from global/misc.c to subs/attsub.c.
Markus Armbruster [Thu, 19 Feb 2004 19:02:30 +0000 (19:02 +0000)]
New server.h for server startup, control and shutdown, i.e. stuff in
src/server. Use it.
Markus Armbruster [Thu, 19 Feb 2004 18:16:34 +0000 (18:16 +0000)]
(check_all_markets, update_wait): Static linkage.
Markus Armbruster [Thu, 19 Feb 2004 18:10:27 +0000 (18:10 +0000)]
Remove useless user.h.
Markus Armbruster [Thu, 19 Feb 2004 17:28:03 +0000 (17:28 +0000)]
Declare update related variables in budg.h. Remove some redundant
declarations elsewhere.
Markus Armbruster [Thu, 19 Feb 2004 16:46:18 +0000 (16:46 +0000)]
Declare all configuration parameters in optlist.h. Remove some
redundant declarations elsewhere.
Markus Armbruster [Thu, 19 Feb 2004 16:39:31 +0000 (16:39 +0000)]
(updating_mob, timestamp_fixing): Inappropriate for global/, move to
update/mobility.c.
(timestamp_fixing, do_upd_checking): Static linkage.
Markus Armbruster [Thu, 19 Feb 2004 16:25:14 +0000 (16:25 +0000)]
Properly declare stuff in headers; remove redundant declarations.
Markus Armbruster [Thu, 19 Feb 2004 15:19:20 +0000 (15:19 +0000)]
(logerror): The version from libcommon.a logs to a file, which is
inappropriate for this program. Log to stderr instead.
(program): Unused, remove.
Markus Armbruster [Thu, 19 Feb 2004 12:39:17 +0000 (12:39 +0000)]
Properly declare functions in headers; remove redundant declarations.
Markus Armbruster [Thu, 19 Feb 2004 12:34:50 +0000 (12:34 +0000)]
(iovec, ioq_peekiov, ioqtoiov): Unused, minor portability
complication, remove.
Markus Armbruster [Thu, 19 Feb 2004 12:00:11 +0000 (12:00 +0000)]
(_noecho, _echo): Broken, portability headache, remove.
(output): Ignore C_NOECHO. Server doesn't send it anyway.
Markus Armbruster [Thu, 19 Feb 2004 10:53:58 +0000 (10:53 +0000)]
Remove some redundant declarations.
Markus Armbruster [Thu, 19 Feb 2004 10:05:53 +0000 (10:05 +0000)]
<string.h> is ISO C, no need to #if it.
Markus Armbruster [Thu, 19 Feb 2004 09:57:25 +0000 (09:57 +0000)]
POSIX has all we need in <time.h>. No need to fool around with
<sys/time.h>.
Markus Armbruster [Thu, 19 Feb 2004 09:20:28 +0000 (09:20 +0000)]
Don't declare library functions, include appropriate headers.
Markus Armbruster [Wed, 18 Feb 2004 21:00:13 +0000 (21:00 +0000)]
(deli): Partial rewrite for clarity, motivated by a `might be used
unitialized' warning. Funcional change: you can now change direction
without threshold (matches documentation, clarify it anyway). Change
prompt for the third argument to reflect that. Also provide context
when prompting for the fourth argument; this is sorely needed we
didn't prompt for the third argument.
Markus Armbruster [Wed, 18 Feb 2004 19:43:09 +0000 (19:43 +0000)]
(player_accept): Back out rev. 1.9, it doesn't compile under Windows.
Needs fixing.
Markus Armbruster [Wed, 18 Feb 2004 19:37:52 +0000 (19:37 +0000)]
(player_coms): Fix c_form for fire.
Markus Armbruster [Wed, 18 Feb 2004 19:35:49 +0000 (19:35 +0000)]
Declare command functions in commands.h. Delete their declarations in
empmod.c
Markus Armbruster [Wed, 18 Feb 2004 19:04:01 +0000 (19:04 +0000)]
Make users of struct cmdstr agree on prototype of member c_addr.
(player_login): Use player->argp[] to store arguments.
(client_cmd, user_cmd, sanc_cmd, coun_cmd, pass_cmd, play_cmd,
kill_cmd, list_cmd, quit_cmd): Remove parameters, fetch arguments from
player->argp[].
(cmdstr): Prototype member c_addr.
(play_cmd): Used to silently ignore up to two arguments if there
wasn't a third one. Don't.
Markus Armbruster [Wed, 18 Feb 2004 11:35:25 +0000 (11:35 +0000)]
(count_planes): Remove declaration. A prototype would need struct
shpstr, but not struct plnstr, which is a strong sign it doesn't
belong here.
Markus Armbruster [Wed, 18 Feb 2004 07:26:09 +0000 (07:26 +0000)]
[_WIN32]: Include required headers.
Markus Armbruster [Wed, 18 Feb 2004 07:12:51 +0000 (07:12 +0000)]
[_EMPTH_WIN32]: Previous rev. didn't even compile, fix.
Markus Armbruster [Tue, 17 Feb 2004 23:01:58 +0000 (23:01 +0000)]
Clean up previous revision.
Markus Armbruster [Tue, 17 Feb 2004 22:58:04 +0000 (22:58 +0000)]
Declare all configuration variables in optlist.h. Include that
instead of declaring them all over the place. This uncovered type
errors:
(s_p_etu, adj_update): Defined long, sometimes declared int. Kills
big endian machines where sizeof(long) != sizeof(int). Change to
int.
(set_option, delete_option, optstrset, intset, floatset, doubleset,
longset, optionset, optiondel, worldxset): Change linkage to static.
Markus Armbruster [Tue, 17 Feb 2004 22:29:59 +0000 (22:29 +0000)]
Remove some superflous declarations missed in the previous revision.
Markus Armbruster [Tue, 17 Feb 2004 18:08:51 +0000 (18:08 +0000)]
Cosmetic.
Markus Armbruster [Tue, 17 Feb 2004 18:05:23 +0000 (18:05 +0000)]
(empth_t, empth_sem_t) [_EMPTH_WIN32]: Use incomplete types, not void for
abstract data types.
Markus Armbruster [Tue, 17 Feb 2004 17:59:30 +0000 (17:59 +0000)]
Supply prototypes where possible. This uncovered type errors with
thread entrypoints:
(lwpSelect, shutdown_sequence): Parameters didn't match thread entry
point prototype.
(lwpEntryPoint): Arguments didn't match thread entry point prototype.
Change linkage of functions without prototype declaration to static
where possible.
Remove some superflous declarations, replace others by suitable
includes.
Markus Armbruster [Mon, 16 Feb 2004 17:44:38 +0000 (17:44 +0000)]
Windows cleanup: include proper headers, remove unused variables, fix
type of signal handler. Mostly from Ron Koenderink.
Markus Armbruster [Sun, 15 Feb 2004 21:27:41 +0000 (21:27 +0000)]
(move_ground): Remove superflous parameter `mobility'. Callers
changed. Edit for clarity. No functional changes.
Markus Armbruster [Sun, 15 Feb 2004 21:00:27 +0000 (21:00 +0000)]
(emp_sig_t): Pre-ISO C compatibility cruft. Just use void.
Markus Armbruster [Sun, 15 Feb 2004 20:28:52 +0000 (20:28 +0000)]
(payo): Previous revision screwed up ally bonus.
Markus Armbruster [Sun, 15 Feb 2004 19:30:03 +0000 (19:30 +0000)]
(upd_ship): Capability fish didn't work together with capability oil.
Markus Armbruster [Sun, 15 Feb 2004 19:26:52 +0000 (19:26 +0000)]
(player_accept): Passed pointer to incorrect type to accept().
Markus Armbruster [Sun, 15 Feb 2004 19:24:08 +0000 (19:24 +0000)]
(clean): Fix for Windows.
Markus Armbruster [Sun, 15 Feb 2004 19:23:42 +0000 (19:23 +0000)]
Fix markup of right quotes.