]> git.pond.sub.org Git - empserver/commit
sail: Remove option SAIL
authorMarkus Armbruster <armbru@pond.sub.org>
Wed, 24 Dec 2014 20:42:51 +0000 (21:42 +0100)
committerMarkus Armbruster <armbru@pond.sub.org>
Sat, 28 Feb 2015 15:11:28 +0000 (16:11 +0100)
commitdc73207a99cf31459eea08629b8cbc327562debf
treedb53fff7862209ece46d3d0f1630685ba8f40695
parent48e656c05742e4c775951e349bd6daf58fdf162a
sail: Remove option SAIL

SAIL has issues:

* Sail orders are executed at the update.  Crafty players can use them
  to get around the update window.

* The route is fixed at command time.  You can't let the update find
  the best route, like it does for distribution.

* The info pages documenting it amount to almost 100 non-blank lines
  formatted.  They claim you can follow friendly ships.  This is
  wrong.  They also show incorrect follow syntax.  Unlikely to be the
  only errors.

* Few players use it.  Makes it a nice hidey-hole for bugs.  Here are
  two nice ones:

  - If follow's second argument is negative, the code attempts to
    follow an uninitialized ship.  Could well be a remote hole.

  - If ship #1 follows #2 follows #3 follows #2, the update goes into
    an infinite loop.

* It's more than 500 lines of rather crufty code nobody wants to
  touch.  Thanks to a big effort in Empire 2, it shares some code with
  the navigation command.  It still duplicates other navigation code.
  The sharing complicates fixing the bugs demonstrated by
  navi-march-test.

Reviewing, fixing and testing this mess isn't worth the opportunity
cost.  Remove it instead.  Drop commands follow, mquota, sail and
unsail.  Drop ship selectors mquota, path, follow.

struct shpstr shrinks some more, on my system from 160 to 120 bytes.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
37 files changed:
include/econfig-spec.h
include/prototypes.h
include/ship.h
info/Update-sequence.t
info/follow.t [deleted file]
info/mission.t
info/mquota.t [deleted file]
info/navigate.t
info/relations.t
info/sail.t [deleted file]
info/unsail.t [deleted file]
src/lib/commands/edit.c
src/lib/commands/foll.c [deleted file]
src/lib/commands/mobq.c [deleted file]
src/lib/commands/sail.c [deleted file]
src/lib/common/nsc.c
src/lib/global/options.c
src/lib/player/empmod.c
src/lib/subs/retreat.c
src/lib/subs/shpsub.c
src/lib/subs/unitsub.c
src/lib/update/sail.c [deleted file]
src/lib/update/ship.c
tests/actofgod/final.xdump
tests/bridgefall/final.xdump
tests/build/final.xdump
tests/fairland/final.xdump
tests/files/final.xdump
tests/fire/final.xdump
tests/navi-march/final.xdump
tests/retreat/01-retreat-1
tests/retreat/final.xdump
tests/retreat/journal.log
tests/retreat/setup-POGO
tests/smoke/fairland.xdump
tests/smoke/final.xdump
tests/smoke/journal.log