From 19953e6c2242b2266b9e8b3ce49f987218d82d19 Mon Sep 17 00:00:00 2001
From: Markus Armbruster <armbru@pond.sub.org>
Date: Sun, 6 Nov 2005 18:06:38 +0000
Subject: [PATCH] (prd_maxno): Variable's value is well-known constant P_MDUST
 + 2. Useless, remove.  Users changed to check pchr's sentinel, because that's
 clearer than comparing the index to P_MDUST or sizeof(pchr) / sizeof(*pchr).

(pchr): Change sentinel's p_name and p_sname to NULL.  Sentinel
checks changed.
---
 include/product.h        | 2 --
 src/lib/global/init.c    | 3 +--
 src/lib/global/product.c | 4 +---
 src/server/main.c        | 2 +-
 4 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/include/product.h b/include/product.h
index 1e296731c..c6326ac54 100644
--- a/include/product.h
+++ b/include/product.h
@@ -77,6 +77,4 @@ struct pchrstr {
 
 extern struct pchrstr pchr[P_MDUST + 2];
 
-extern int prd_maxno;
-
 #endif /* _PRODUCT_H_ */
diff --git a/src/lib/global/init.c b/src/lib/global/init.c
index 2839b7d5c..beb14f349 100644
--- a/src/lib/global/init.c
+++ b/src/lib/global/init.c
@@ -86,9 +86,8 @@ static void
 init_pchr(void)
 {
     struct pchrstr *p;
-    int pcount;
 
-    for (p = pchr, pcount = 0; pcount < prd_maxno; pcount++, p++) {
+    for (p = pchr; p->p_name; p++) {
 	if (opt_GO_RENEW) {
 	    if (p->p_type == I_DUST || p->p_type == I_OIL)
 		p->p_nrdep = 0;
diff --git a/src/lib/global/product.c b/src/lib/global/product.c
index 6a9ac1dfc..f4b985608 100644
--- a/src/lib/global/product.c
+++ b/src/lib/global/product.c
@@ -92,7 +92,5 @@ struct pchrstr pchr[] = {
      I_DUST, -1, 0, offsetof(struct sctstr, sct_gmin), 20, -1, 0, 0, 75,
      "gold dust", "dust",},
     {{I_NONE, I_NONE, I_NONE}, {0, 0, 0},
-     I_NONE, 0, 0, 0, 0, 0, 0, 0, 0, "", "",}
+     I_NONE, 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL,}
 };
-
-int prd_maxno = (sizeof(pchr) / sizeof(struct pchrstr)) - 1;
diff --git a/src/server/main.c b/src/server/main.c
index 4a2778ae6..bec77d3d7 100644
--- a/src/server/main.c
+++ b/src/server/main.c
@@ -531,7 +531,7 @@ nullify_objects(void)
 	if (opt_NO_LCMS)
 	    dchr[i].d_lcms = 0;
     }
-    for (i = 0; i < prd_maxno; i++) {
+    for (i = 0; pchr[i].p_name; i++) {
 	for (j = 0; j < MAXPRCON; j++) {
 	    if (opt_NO_HCMS && pchr[i].p_ctype[j] == I_HCM)
 		pchr[i].p_camt[j] = 0;
-- 
2.43.0