From 25115f4997294ab16c7ddd427e4fc67a89bd73cd Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Sun, 4 Jul 2010 17:30:03 +0200 Subject: [PATCH] Document xundump() memory leak more clearly --- src/lib/common/xundump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/common/xundump.c b/src/lib/common/xundump.c index 05a0b1977..3be1f24b1 100644 --- a/src/lib/common/xundump.c +++ b/src/lib/common/xundump.c @@ -615,6 +615,7 @@ setstr(int fldno, char *str) case NSC_STRING: old = ((char **)memb_ptr)[idx]; if (!must_match) + /* FIXME may leak old value */ ((char **)memb_ptr)[idx] = str ? strdup(str) : NULL; len = 65535; /* really SIZE_MAX, but that's C99 */ break; -- 2.43.0