From 8b7c78b5fa46de70eefc0ac54feee436d381917d Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Thu, 15 Mar 2012 21:38:29 +0100 Subject: [PATCH] Fix execute's printing of the executed commands If execute's argument was read interactively, it prints the argument instead of the command. Else, it prints uninitialized garbage. The latter can theoretically crash the server, or leak information. Broken in commit 3de1e8be, v4.3.28 --- src/lib/player/player.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/player/player.c b/src/lib/player/player.c index 35b1ca091..2a489392d 100644 --- a/src/lib/player/player.c +++ b/src/lib/player/player.c @@ -254,12 +254,12 @@ execute(void) continue; } pr("\nExecute : "); - uprnf(buf); + uprnf(player->combuf); pr("\n"); if (redir) { pr("Execute : redirection not supported\n"); failed = 1; - } else if (dispatch(buf, NULL) < 0) + } else if (dispatch(player->combuf, NULL) < 0) failed = 1; empth_yield(); } -- 2.43.0