fix ajax update handler, break lines

[eow] / web.lisp

diff --git a/web.lisp b/web.lisp
index 96fcb29d51da10120c0dd1e6a8004d6c03c5356d..127a87ecc7bb61716f5e454b96ad946b7efa1bf7 100644 (file)
--- a/web.lisp
+++ b/web.lisp
@@ -37,6 +37,10 @@
     :accessor update-queue
     :initform (locked-queue:create)
     :documentation "Updates to be sent to the browser")
+   (update-thread
+    :accessor update-thread
+    :initform nil
+    :documentation "COMET thread waiting for updates of non-NIL")
    (connection
    :accessor connection
    :documentation "Connection to the empire game server")))
@@ -64,7 +68,21 @@
 (defun update ()
   "Send stream of updates to client"
   (with-session
-    (locked-queue:dequeue (update-queue *empire-session*))))
+    ; kill previous update thread
+    (when (update-thread *empire-session*)
+      (empire-log:info "~a: Killing update thread ~a."
+                      *empire-session* (update-thread *empire-session*))
+      (sb-thread:terminate-thread (update-thread *empire-session*)))
+
+    ; make current thread the update thread
+    (setf (update-thread *empire-session*) sb-thread:*current-thread*)
+
+    (let ((next-updates (locked-queue:dequeue-all (update-queue *empire-session*))))
+      ; There's a race here. The next update thread might kill this one before
+      ; sending the reply.
+      (setf (update-thread *empire-session*) nil)
+      (nconc next-updates (list (parenscript:ps* '(next))))
+      (apply #'concatenate 'string next-updates))))
 
 (defmethod send ((s session) string)
   "Push a javascript update fragment to the client."
@@ -97,16 +115,21 @@
   (with-session
     (hunchentoot:handle-static-file (concatenate 'string +static-files-root+ +root-page-file+))))
 
+(defun my-request-p (script-name)
+  (string-starts-with script-name +web-root+))
+
 (defun dispatch (request)
   (let ((script-name (hunchentoot:script-name request)))
     (cond
-      ((not (string-starts-with script-name +web-root+)) nil) ; do not handle this request
+      ((not (my-request-p script-name)) nil) ; do not handle this request
       ((string= script-name "/eow/update") 'update)
       ((string= script-name "/eow/login") 'login-action)
       ((string= script-name "/eow/command") 'command-action)
+                                       ; go to the start page
       ((or (string-equal script-name +web-root-base+)
-           (string-equal script-name +web-root+)) 'root-page) ; go to the start page
-      ((string-starts-with script-name +static-web-root+) 'serve-static)))) ; serve static file
+           (string-equal script-name +web-root+)) 'root-page)
+                                       ; serve static file
+      ((string-starts-with script-name +static-web-root+) 'serve-static))))
 
 
 (defun start ()