From 122cb5fc3b685bfb87050647ee8774302c88366c Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Sun, 11 Aug 2013 13:53:52 +0200 Subject: [PATCH] accept: Drop outdated FIXME SO_KEEPALIVE SO_KEEPALIVE isn't useless with long idle timeouts. Before v4.3.30's idle timeout changes, such long timeouts had serious drawbacks (easy denial of service), but they're just fine since then. Signed-off-by: Markus Armbruster --- src/lib/player/accept.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/player/accept.c b/src/lib/player/accept.c index ca060654..ba022c21 100644 --- a/src/lib/player/accept.c +++ b/src/lib/player/accept.c @@ -201,7 +201,6 @@ player_accept(void *unused) logerror("new socket accept"); continue; } - /* FIXME SO_KEEPALIVE is useless, player_kill_idle() strikes long before */ (void)setsockopt(ns, SOL_SOCKET, SO_KEEPALIVE, &set, sizeof(set)); np = player_new(ns); if (!np) {