empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix new_seqno()'s recovery from seqno mismatch

Browse source 
A sequence number mismatch occurs when an invalid copy (with a stale
sequence number) gets written.  To continue after the error, we need
to use the current sequence number.  But new_seqno() used the larger
one of the two, which is correct only as long as sequence numbers do
not overflow.  Overflow is rather unlikely, though.
This commit is contained in:
Markus Armbruster 2009-12-31 12:12:39 +01:00
parent 0ba61f1714
commit 18148f03fa
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/lib/common/file.c
View file

@ -603,8 +603,7 @@ new_seqno(struct empfile *ep, void *buf)
if (!(ep->flags & EFF_TYPED))
return;
old_seqno = get_seqno(ep, elt->uid);
if (CANT_HAPPEN(old_seqno != elt->seqno))
old_seqno = MAX(old_seqno, elt->seqno);
CANT_HAPPEN(old_seqno != elt->seqno);
elt->seqno = old_seqno + 1;
}