empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cutoff level: Add FIXME comments to narrow coordinate columns

Browse source 
When formatting coordinates for fixed-width output, the width should
be at least four characters.

cutoff was fine until 4.0.2 reduced coordinate width to three to make
space for civilian and military delivery thresholds.

level has always used width three.

Can't fix either without making lines too long or dropping
information, so just document the problem for now.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
Markus Armbruster 2013-05-26 11:31:21 +02:00
parent 3abfde408d
commit 1b07fd62c2
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/lib/commands/cuto.c
View file

@ -62,7 +62,7 @@ cuto(void)
} }
if (player->god) if (player->god)
pr("%3d", sect.sct_own); pr("%3d", sect.sct_own);
prxy("%3d,%-3d", nstr.x, nstr.y); prxy("%3d,%-3d", nstr.x, nstr.y); /* FIXME too narrow */
pr(" %c ", dchr[sect.sct_type].d_mnem); pr(" %c ", dchr[sect.sct_type].d_mnem);
pr("%c", dirstr[sect.sct_del[I_CIVIL] & 0x7]); pr("%c", dirstr[sect.sct_del[I_CIVIL] & 0x7]);
pr("%c", dirstr[sect.sct_del[I_MILIT] & 0x7]); pr("%c", dirstr[sect.sct_del[I_MILIT] & 0x7]);

4
src/lib/commands/leve.c
View file

@ -56,9 +56,9 @@ leve(void)
} }
if (player->god) if (player->god)
pr("%2d ", sect.sct_own); pr("%2d ", sect.sct_own);
prxy("%3d,%-3d", nstr.x, nstr.y); prxy("%3d,%-3d", nstr.x, nstr.y); /* FIXME too narrow */
pr(" %c ", dchr[sect.sct_type].d_mnem); pr(" %c ", dchr[sect.sct_type].d_mnem);
prxy("%3d,%-3d", sect.sct_dist_x, sect.sct_dist_y); prxy("%3d,%-3d", sect.sct_dist_x, sect.sct_dist_y); /* FIXME too */
pr(" %4d", sect.sct_dist[I_CIVIL]); pr(" %4d", sect.sct_dist[I_CIVIL]);
pr("%4d", sect.sct_dist[I_MILIT]); pr("%4d", sect.sct_dist[I_MILIT]);
pr("%4d", sect.sct_dist[I_UW]); pr("%4d", sect.sct_dist[I_UW]);