From 1e17cc77cb702b41418a002811761f36ca79dcc7 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Sun, 5 Feb 2006 19:13:58 +0000 Subject: [PATCH] (verify_row): if/else with negated condition is confusing. Negate condition, swap conditional statements. --- src/lib/common/ef_verify.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/common/ef_verify.c b/src/lib/common/ef_verify.c index 755e951f..9e26ac4b 100644 --- a/src/lib/common/ef_verify.c +++ b/src/lib/common/ef_verify.c @@ -52,12 +52,12 @@ verify_row(int type, int row) int ret_val = 0; int in_mem = (ef_flags(type) & EFF_MEM) != 0; - - if (!in_mem) { - row_ref = malloc(empfile[type].size); - ef_read(type, row, row_ref); - } else + if (in_mem) row_ref = ef_ptr(type, row); + else { + row_ref = malloc(empfile[type].size); + ef_read(type, row, row_ref); + } for (i = 0; ca[i].ca_name; ++i) { if (ca[i].ca_flags & NSC_EXTRA)