Generation numbers to catch write back of stale copies
Oops when a stale copy is written back, i.e. the processor was yielded since the copy was made. Such bugs are difficult to spot. Sequence numbers catch them when they do actual harm (they also catch different bugs). Generation numbers catch them even when they don't. New ef_generation to count generations. Call new ef_make_stale() to step it whenever the processor may be yielded. New struct emptypedstr member generation. Make sure all members of unit empobj_storage share it. It is only used in copies; its value on disk and in the cache is meaningless. Set it to ef_generation by calling new ef_mark_fresh() when making copies in ef_read() and ef_blank(). Do the same in obj_changed() to make check_sect_ok() & friends freshen their argument when it is unchanged. Copies with generation other than ef_generation are stale. Oops in ef_write() when a stale copy is written back.
This commit is contained in:
parent
f8be963202
commit
20b31defe7
19 changed files with 82 additions and 3 deletions
|
@ -58,6 +58,7 @@ struct empobj {
|
|||
short ef_type;
|
||||
short uid;
|
||||
unsigned seqno;
|
||||
unsigned generation;
|
||||
time_t timestamp;
|
||||
/* end of part matching struct emptypedstr */
|
||||
natid own; /* valid if EFF_OWNER is in table's flags */
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue