Generation numbers to catch write back of stale copies
Oops when a stale copy is written back, i.e. the processor was yielded since the copy was made. Such bugs are difficult to spot. Sequence numbers catch them when they do actual harm (they also catch different bugs). Generation numbers catch them even when they don't. New ef_generation to count generations. Call new ef_make_stale() to increment it whenever the processor may be yielded. New struct emptypedstr member generation. To conserve space, make it a bit-field of twelve bits, i.e. generations are only recorded modulo 2^12. Make sure all members of unit empobj_storage share it. It is only used in copies; its value on disk and in the cache is meaningless. Copies with generation other than ef_generation are stale. Stale copies that are a multiple of 2^12 generations old can't be detected, but that is sufficiently improbable. Set generation to ef_generation by calling new ef_mark_fresh() when making copies in ef_read() and ef_blank(). nav_ship() and fltp_to_list() make copies without going through ef_read(), and therefore need to call ef_mark_fresh() as well. Also call it in obj_changed() to make check_sect_ok() & friends freshen their argument when it is unchanged. New must_be_fresh() oopses when its argument is stale. Call it in ef_write() to catch write back of stale copies.
This commit is contained in:
parent
358aee203e
commit
2fa5f65257
22 changed files with 93 additions and 3 deletions
|
@ -44,6 +44,7 @@ struct nukstr {
|
|||
/* initial part must match struct empobj */
|
||||
signed ef_type: 8;
|
||||
unsigned nuk_seqno: 12;
|
||||
unsigned nuk_generation: 12;
|
||||
int nuk_uid; /* unit id (nuke #) */
|
||||
time_t nuk_timestamp; /* Last time this nuke was touched */
|
||||
natid nuk_own;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue