empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove option SLOW_WAR

Browse source 
SLOW_WAR has issues:

* The check whether the attacker old-owns the attacked sector is
  broken, because att_abort() uses sect.sct_oldown uninitialized.

  Spotted by the Clang Static Analyzer.

* Its implementation in setrel() is somewhat scary.  It's actually
  okay, because that part of setrel() only runs within decl().  Other
  callers don't reach it: update_main() because player->god != 0
  there, and the rest because they never pass a rel < HOSTILE.

* Documentation is a bit vague.

SLOW_WAR hasn't been used in a public game in years.  Fixing it is not
worth it, so remove it instead.
This commit is contained in:
Markus Armbruster 2011-01-09 19:03:38 +01:00
parent a94ae5f8c1
commit 439f111f98
23 changed files with 11 additions and 274 deletions
Download patch file Download diff file Expand all files Collapse all files

25
info/declare.t
View file

@ -15,31 +15,6 @@ which case you will declare <POSITION> towards all nations.
For a complete list of the meanings of all the different types of
relations, see "info relations".
.s1
GOING TO WAR
.s1
(Note: the following stuff is only in effect if the SLOW_WAR option is selected)
With the SLOW_WAR option in use, you cannot attack the land of someone you are
not at war with. When you declare war on
someone, your relation goes to \*Qmobilizing\*U. You still can't attack them.
After the next update, your relation goes to \*Qsitzkrieg\*U, and you still
can't attack them. After the NEXT update, you're at war with them, and anything
goes.
.s1
If someone is \*Qmobilizing\*U or in \*Qsitzkrieg\*U, or at war with you,
and you
declare war against them, your relation is set to be the same as theirs, so
there is no way to gain any advantage through this stuff. It just means that
you can't sneak-attack people.
.s1
The first person who declares war pays $1000. Return declarations are
free.
.s1
There is an exception to the SLOW_WAR restrictions. If you are listed as
the old owner of a sector, you are still allowed to attack it. This is to
prevent someone from declaring war with you, taking some sectors, then
declaring neutrality before you declare war. (Assuming you didn't notice
their declaration of war)
.s1
The newspaper is very interested in declarations of war or alliance --
don't expect to keep such declarations secret.
.s1