empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the demand update feature veto. It's virtually unused, flawed

Browse source 
by design (by voting last players can tactically vote no and thus
build up veto rights), and its implementation is buggy:
(update_missed): Remove.
(zdone): Don't show it.
(demand_check): Remove veto check.
(natstr, cou_ca): Remove member nat_missed and its selector.
(zdone): Don't clear and don't show it.
(update_removewants): Don't increment it.  This was buggy anyway; it
incremented even on non-demand updates.
(prnat): Don't show it, remove key 'U'.
(docountry): Don't change it, deprecate the now useless key 'U'.
This commit is contained in:
Markus Armbruster 2007-07-14 13:09:33 +00:00
parent ec98ff03f3
commit 4ba4cd98c6
8 changed files with 3 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/lib/commands/edit.c
View file

@ -299,7 +299,6 @@ prnat(struct natstr *np)
pr("Happiness <H>: %.2f\n", np->nat_level[NAT_HLEV]);
pr("Money <M>: $%6ld\n", np->nat_money);
pr("Telegrams <t>: %6d\n", np->nat_tgms);
pr("Updates missed <U>: %d\n", np->nat_missed);
if (opt_HIDDEN) {
pr("Countries contacted: ");
for (i = 0; i < MAXNOC; i++) {
@ -745,7 +744,7 @@ docountry(char op, int arg, char *p, struct natstr *np)
np->nat_level[NAT_HLEV] = farg;
break;
case 'U':
np->nat_missed = arg;
warn_deprecated(op);
break;
default:
pr("huh? (%c)\n", op);

5
src/lib/commands/zdon.c
View file

@ -111,7 +111,6 @@ zdon(void)
pr("Unable to request an update as the country is in flux\n");
return RET_FAIL;
}
natp->nat_missed = 0;
pr("You (%d) now want an update.\n", whichcnum);
} else {
pr("You (%d) now DON'T want an update.\n", whichcnum);
@ -126,10 +125,6 @@ zdon(void)
pr("You want an update.\n");
} else
pr("You DON'T want an update, yet.\n");
pr("You have missed the vote on a demand update %d times.\n",
natp->nat_missed);
pr("It takes %d misses to veto a demand update.\n",
update_missed);
}
pr("%d of a total of %d lunatics want an update.\n", totwant, totpop);