empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(io_open, io_iopfromfd): Properly check argument FD to protect

Browse source 
io_list[] indexing.
(niop, io_init): Store length of io_list[] in new niop.
(player_accept): Checking the socket file descriptor here is now
redundant.  Remove.
This commit is contained in:
Markus Armbruster 2004-02-06 12:12:58 +00:00
parent 0655744bf7
commit 52cb1f8c55
2 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/lib/player/accept.c
View file

@ -200,7 +200,6 @@ player_accept(void *argv)
int s;
short port;
int val;
int maxfd;
struct player *np;
int len;
int ns;
@ -248,7 +247,6 @@ player_accept(void *argv)
exit(1);
}
#endif
maxfd = getfdtablesize() - 1;
while (1) {
empth_select(s, EMPTH_FD_READ);
len = sizeof(sin);
@ -259,12 +257,6 @@ player_accept(void *argv)
}
(void)setsockopt(ns, SOL_SOCKET, SO_KEEPALIVE,
(char *)&set, sizeof(set));
if (ns >= maxfd) {
logerror("new fd %d, max %d, no fd's left for new user",
ns, maxfd);
close(ns);
continue;
}
np = player_new(ns, &sin);
if (!np) {
logerror("can't create player for fd %d", ns);