empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

subs: Drop unused spy detection roll from unitsatxy()

Browse source 
The die roll was added in 4.0.17 to hide spies from bombers.  However,
players could roll dice as often as they wanted, by typing '?' at the
target prompt.  The broken die roll is unreachable since commit
7688aed disallowed bombing of spies.  Drop it.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
Markus Armbruster 2016-07-21 21:00:47 +02:00
parent 2402f3f2a2
commit 656c3e7645
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/lib/subs/list.c
View file

@ -124,7 +124,6 @@ unitsatxy(coord x, coord y, int wantflags, int nowantflags)
while (nxtitem(&ni, &land)) { while (nxtitem(&ni, &land)) {
if (land.lnd_effic < LAND_MINEFF || land.lnd_own == 0) if (land.lnd_effic < LAND_MINEFF || land.lnd_own == 0)
continue; continue;
/* Can't bomb units on ships or other units */
if (land.lnd_ship >= 0 || land.lnd_land >= 0) if (land.lnd_ship >= 0 || land.lnd_land >= 0)
continue; continue;
lp = &lchr[(int)land.lnd_type]; lp = &lchr[(int)land.lnd_type];
@ -138,11 +137,6 @@ unitsatxy(coord x, coord y, int wantflags, int nowantflags)
continue; continue;
} }
if (lp->l_flags & L_SPY) {
if (!(chance(LND_SPY_DETECT_CHANCE(land.lnd_effic))))
continue;
}
if (!units) if (!units)
pr(" # owner eff type\n"); pr(" # owner eff type\n");
pr("(#%3d) %10.10s %12.12s %s\n", ni.cur, pr("(#%3d) %10.10s %12.12s %s\n", ni.cur,