empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Abstract from update trigger mechanism:

Browse source 
(update_trigger): New.
(force, zdon): Use it.
(update_sem, update_force): Internal linkage.

(update_trigger, update_force): Passing a pointer to static storage as
thread argument is racy.  Use dynamic allocation.
This commit is contained in:
Markus Armbruster 2007-01-19 06:46:10 +00:00
parent 553662f305
commit 861112f827
4 changed files with 38 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/lib/commands/forc.c
View file

@ -34,13 +34,12 @@
#include <config.h>
#include "commands.h"
#include "empthread.h"
#include "server.h"
int
force(void)
{
static int seconds;
int seconds;
if (update_pending) {
pr("Update is pending\n");
@ -59,7 +58,7 @@ force(void)
return RET_FAIL;
pr("Scheduling update in %d second(s)\n", seconds);
empth_create(PP_SCHED, update_force, (50 * 1024), 0, "forceUpdate",
"Schedules an update", &seconds);
if (update_trigger(seconds) < 0)
return RET_FAIL;
return RET_OK;
}

3
src/lib/commands/zdon.c
View file

@ -52,7 +52,6 @@
#include <config.h>
#include "commands.h"
#include "empthread.h"
#include "optlist.h"
#include "server.h"
@ -142,7 +141,7 @@ zdon(void)
if (!checking && wantupd && demandupdatecheck()) {
pr("Here goes...\n");
empth_sem_signal(update_sem);
update_trigger(0);
}
return RET_OK;
}