empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix pre-tax unit market price loss of precision

Browse source 
check_trade() converts the price to float, which can lose precision,
although only for ridiculously high prices.  Has been broken since
4.0.0 introduced the market.

Avoid the conversion.  Bulletins now show pre-tax price as $N instead
of $N.00.
This commit is contained in:
Markus Armbruster 2013-01-14 20:52:04 +01:00
parent 5f46ced826
commit 9c78e724ab
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/lib/commands/trad.c
View file

@ -283,7 +283,7 @@ check_trade(void)
union empobj_storage tg; union empobj_storage tg;
time_t now; time_t now;
double tleft; double tleft;
float price; int price;
int saveid; int saveid;
natid seller; natid seller;
@ -338,7 +338,7 @@ check_trade(void)
wu(0, seller, wu(0, seller,
" Your item was taken off the market.\n"); " Your item was taken off the market.\n");
wu(0, trade.trd_maxbidder, wu(0, trade.trd_maxbidder,
"You tried to buy %s #%d from %s for $%.2f\n", "You tried to buy %s #%d from %s for $%d\n",
trade_nameof(&trade, &tg.gen), saveid, cname(seller), trade_nameof(&trade, &tg.gen), saveid, cname(seller),
price); price);
wu(0, trade.trd_maxbidder, "but couldn't afford it.\n"); wu(0, trade.trd_maxbidder, "but couldn't afford it.\n");
@ -403,7 +403,7 @@ check_trade(void)
cname(trade.trd_maxbidder), trade_nameof(&trade, &tg.gen), cname(trade.trd_maxbidder), trade_nameof(&trade, &tg.gen),
saveid, price * tradetax); saveid, price * tradetax);
wu(0, trade.trd_maxbidder, wu(0, trade.trd_maxbidder,
"The bidding is over & you bought %s #%d from %s for $%.2f\n", "The bidding is over & you bought %s #%d from %s for $%d\n",
trade_nameof(&trade, &tg.gen), saveid, cname(seller), trade_nameof(&trade, &tg.gen), saveid, cname(seller),
price); price);
} }