Remove option TREATIES
TREATIES has issues: * Treaties can cover attack, assault, paradrop, board, lboard, fire, build (s|p|l|n) and enlist, but not bomb, launch, torpedo and enlistment centers. * Usability is very poor. While a treaty is in effect, every player action that violates a treaty condition triggers a prompt like this: This action is in contravention of treaty #0 (with Curmudgeon) Do you wish to go ahead anyway? [yn] If you decline, the action is not executed. If you accept, it is. In both cases, your decision is reported in the news. You cannot get rid of these prompts until the treaty expires. * Virtually nobody uses them. * Virtually unused code is buggy code. There is at least one race condition: multifire() reads the firing sector, ship or land unit before the treaty prompt, and writes it back after, triggering a generation oops. Any updates made by other threads while trechk() waits for input are wiped out, triggering a seqno mismatch oops. * The treaty prompts could confuse smart clients that aren't prepared for them. WinACE isn't, but is reported to work anyway at least common usage. Ron Koenderink (the WinACE maintainer) suspects there could be a few situations where it will fail. This feature is not earning its keep. Remove it. Drop command treaty, consider treaty, offer treaty, xdump treaty, reject treaties. Output of accept changed, obviously. Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
parent
b2090ed34f
commit
a109de948b
60 changed files with 415 additions and 1300 deletions
|
@ -38,7 +38,7 @@
|
|||
struct empfile {
|
||||
/* Members with immutable values */
|
||||
int uid; /* Table ID */
|
||||
char *name; /* Empire name (e.g., "treaty") */
|
||||
char *name; /* Empire name (e.g., "land") */
|
||||
char *pretty_name; /* prettier name, e.g. "land unit" */
|
||||
char *file; /* file name, relative to gamedir for
|
||||
game state, to builtindir for config */
|
||||
|
@ -146,7 +146,6 @@ enum {
|
|||
EF_LAND,
|
||||
EF_NUKE,
|
||||
EF_NEWS,
|
||||
EF_TREATY,
|
||||
EF_TRADE,
|
||||
EF_POWER,
|
||||
EF_NATION,
|
||||
|
@ -194,7 +193,6 @@ enum {
|
|||
EF_RETREAT_FLAGS,
|
||||
EF_SECTOR_NAVIGATION,
|
||||
EF_SHIP_CHR_FLAGS,
|
||||
EF_TREATY_FLAGS,
|
||||
/* Views */
|
||||
EF_COUNTRY,
|
||||
/* Number of types: */
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue