empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clean up poorly chosen loop control variable names

Browse source 
Calling a counting loop's control variable q or x is tasteless
bordering on actively misleading.
This commit is contained in:
Markus Armbruster 2009-02-21 15:30:13 +01:00
parent a2557a1dec
commit a61e673a07
5 changed files with 47 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/lib/commands/trad.c
View file

@ -72,7 +72,7 @@ trad(void)
int bid;
double tleft;
double tally;
int q;
int i;
char buf[1024];
if (!opt_MARKET) {
@ -164,13 +164,13 @@ trad(void)
return RET_OK;
}
tally = 0.0;
for (q = 0; gettrade(q, &tmpt); q++) {
for (i = 0; gettrade(i, &tmpt); i++) {
if (tmpt.trd_maxbidder == player->cnum &&
tmpt.trd_unitid >= 0 && tmpt.trd_owner != player->cnum) {
tally += tmpt.trd_price * tradetax;
}
}
for (q = 0; getcomm(q, &comt); q++) {
for (i = 0; getcomm(i, &comt); i++) {
if (comt.com_maxbidder == player->cnum &&
comt.com_owner != 0 && comt.com_owner != player->cnum) {
tally += (comt.com_price * comt.com_amount) * buytax;