empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clean up poorly chosen loop control variable names

Browse source 
Calling a counting loop's control variable q or x is tasteless
bordering on actively misleading.
This commit is contained in:
Markus Armbruster 2009-02-21 15:30:13 +01:00
parent a2557a1dec
commit a61e673a07
5 changed files with 47 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/lib/common/path.c
View file

@ -182,7 +182,7 @@ bp_neighbors(struct as_coord c, struct as_coord *cp, void *pp)
struct bestp *bp = pp;
coord x, y;
coord nx, ny;
int n = 0, q;
int n = 0, i;
struct sctstr *sp, *from, **ssp;
/* Six pointers, just in case our cache isn't there */
struct sctstr *tsp[] = { NULL, NULL, NULL, NULL, NULL, NULL };
@ -199,11 +199,11 @@ bp_neighbors(struct as_coord c, struct as_coord *cp, void *pp)
ssp = (struct sctstr **)&tsp[0];
else
ssp = (struct sctstr **)&neighsects[offset * 6];
for (q = 1; q <= 6; q++, ssp++) {
for (i = 1; i <= 6; i++, ssp++) {
if (*ssp == NULL) {
/* We haven't cached this neighbor yet */
nx = x + diroff[q][0];
ny = y + diroff[q][1];
nx = x + diroff[i][0];
ny = y + diroff[i][1];
sx = XNORM(nx);
sy = YNORM(ny);
offset = XYOFFSET(sx, sy);