(nxtitem): Skipped unowned sectors (could not occur), ships, planes,

land units and nukes for selection type NS_LIST.  Thus, unowned items
explicitly selected by item number are skipped, while the same items
selected implicitely by group, area or whatever are not.  This makes
no sense.  Some callers break the nstr_item abstraction to prevent the
skipping, so they get all items regardless of how they were selected.
All other callers filter out unowned items.  This skipping misfeature
dates back to the very oldest known versions of Empire.  Remove it.
Also remove skipping prevention hacks from callers.

(tend_nxtitem): Now identical to nxtitem(), except it lacks some extra
normalization of item coordinates, which should have no effect.
Replace by nxtitem().
This commit is contained in:
Markus Armbruster 2005-05-29 13:15:56 +00:00
parent 15448392f3
commit b111abc2c5
7 changed files with 3 additions and 94 deletions

View file

@ -103,7 +103,7 @@ ltend(void)
if (!check_ship_ok(&tender))
return RET_FAIL;
total = 0;
while (tend_nxtitem(&targets, (s_char *)&target)) {
while (nxtitem(&targets, (s_char *)&target)) {
if (!player->owner)
continue;