empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

budget: Avoid unnecessary work

Browse source 
Ship, plane and land unit repairs depend on and change the state of
the sector.  To predict repairs, we need to predict the state of the
sector before repairs.  The obvious way to do that is to simulate the
sector update and all ship, plane and land unit updates there in the
correct order.

Until recently, we simulated only own sectors, ships, planes and land
units.  Wrong when foreign sectors, ships, planes or land units are
involved.  The fix (commit 70f6964) makes budget simulate all
countries.  Correct, but does much more work than necessary.  With a
little effort, we can track what needs to be simulated.

Use the bp map for tracking.  We need to mark the player's sectors and
all sectors where he has ships, planes or land units.  Do the former
in bp_alloc(), and the latter in prep_ships(), prep_planes(),
prep_lands().

Skip sectors not so marked.  This requires delaying prepare_sects()
until after prep_ships(), prep_planes(), prep_lands().  Their order
doesn't actually matter: prep_ships() & friends only spend money, and
nothing in preparation depends on whether the country is still
solvent.

Skip ships, planes and land units in sectors not so marked.

This speeds up budget by around a third in my testing, more for small
countries.  Roughly 15% slower than before the fix for repairs abroad.
The update has to do a bit more work than before, but the performance
difference is lost in the noise.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
Markus Armbruster 2016-07-16 12:38:24 +02:00
parent 549561ff03
commit b6509b7309
10 changed files with 82 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

14
info/Update-sequence.t
View file

@ -6,7 +6,13 @@ This document gives a rough order of events during the update.
.s1
.nf
1) Prepare
a) prepare all sectors
a) prepare all ships
a) pay military on board
b) prepare all planes
a) pay crew
c) prepare all land units
a) pay military on board
d) prepare all sectors
a) fallout is checked, if FALLOUT is defined
b) guerrilla warfare is checked
c) if the sector doesn't have the plague, see if it
@ -17,12 +23,6 @@ This document gives a rough order of events during the update.
e) taxes are collected from civs & uws; mil are paid.
f) if the sector is a bank it makes $$ proportional to
its efficiency
b) prepare all ships
a) pay military on board
c) prepare all planes
a) pay crew
d) prepare all land units
a) pay military on board
e) pay for military reserves.
2) Produce