From bd0d5c10b6f4eaac96c9d587b3dda0b33ae0e286 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Thu, 15 Nov 2007 19:03:27 +0000 Subject: [PATCH] (execute): Prompted for a missing argument, but then passed a null pointer to prexec() instead. Some systems (GNU, Windows) deal gracefully with printing null strings, others crash. --- src/lib/player/player.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lib/player/player.c b/src/lib/player/player.c index dc919f47..3b9e789e 100644 --- a/src/lib/player/player.c +++ b/src/lib/player/player.c @@ -278,13 +278,11 @@ execute(void) failed = 0; redir = NULL; + /* FIXME should use raw argument here, to support UTF-8 file names */ p = getstarg(player->argp[1], "File? ", buf); - if (p == NULL || *p == '\0') return RET_SYN; - - /* FIXME should use raw argument here, to support UTF-8 file names */ - prexec(player->argp[1]); + prexec(p); while (!failed && status()) { if (recvclient(buf, sizeof(buf)) < 0)