empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Notes added by 'git notes add'

Browse source
This commit is contained in:
Markus Armbruster 2012-03-28 19:19:57 +02:00
parent 47b42c1c8f
commit c140f9ef65
1 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
904822e3449f35ab1dd7a0cbaa924b4e0a406a0a Normal file
View file

@ -0,0 +1,17 @@
Login command quit has the same problem. I believe it could always
lose output.
Before Empire 2, quit_cmd() tried to flush output, threw away anything
it couldn't flush, then closed the connection.
Empire 2's quit_cmd() shut down the input direction of the connection
right away. This terminated the command loop, and led to connection
close. I believe it also made client input sends fail with ECONNRESET
right away.
Since commit 0a7306a5, the input shutdown is gone. We get behavior
similar to server shutdown: command loop terminates, which leads to
close of the server's end of the connection.
In all cases, client sending input after input shutdown or connection
close fails with ECONNRESET, and remaining output is lost.