Use gcc function attribute `format' to catch bad format strings. Fix

them.  From Marc Olzheim.
Type modifier 'l' was missing in many places, probably rendering the
server useless on 64-bit hosts.
(ef_flush, ef_write, ef_extend, lwpCreate, lwpDestroy): Use conversion
specifier 'p' to print pointers.
(check_market): Fix display of loan amount.
(doland): Fix unescaped '%' (undefined behavior).
(ldump, ndump, pdump, sdump): Don't use flag '0' with conversion
specifier 's' (undefined behavior).
(dump, ldump, lost, ndump, pdump, sdump, empth_create, update_sched):
Cast time_t and pthread_t to long for printing.
(lwpStackCheck, lwpStackCheckUsed, finish_sects): Insert cast to fix
argument type on all platforms.
(prod): Remove extra argument.
(perform_mission, airdamage, retreat_land1, lwpReschedule): Format
string missed arguments.

src/lib/update/finish.c

@@ -94,10 +94,9 @@ finish_sects(int etu)
 	    return;
 	}
 
-	logerror("Allocated '%d' bytes '%d' indices\n",
-		 ((WORLD_X * WORLD_Y) * sizeof(struct distinfo)),
-		 (WORLD_X * WORLD_Y));
-
+	logerror("Allocated '%lu' bytes '%d' indices\n",
+		 (unsigned long)(WORLD_X * WORLD_Y * sizeof(struct distinfo)),
+		 WORLD_X * WORLD_Y);
     }
 
     /* Wipe it clean */