empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: New test-suite-only command __cmd

Browse source 
Adding or removing a command to/from a test has unfortunate effects:

* Before the previous commit: if the command consumes pseudorandom
  numbers, all subsequent users of pseudorandom numbers get different
  ones.  This has always been a major headache.

* Since the previous commit: all subsequent users of pseudorandom
  numbers get different ones whether the command consumes any or not.
  That's even worse.

* If the command uses BTUs, subsequent prompts are changed.  Not
  nearly as bad as the above, but still annoying.

Create a new command __cmd to allow compensating for adding/removing
commands for tests.  Throw in the ability to compensate treasury
changes for good measure.  Three arguments: command count, BTU use,
money use.

Usage example: say you add a convert command to a test, and it uses 3
BTUs and $15.  Then you compensate by adding "__cmd added 1 3 15"
right after it.

The command must not be available unless running_test_suite is on, of
course.  Make it require the new player command capability TESTING,
and give that to all players when running_test_suite is on.

The command is intentionally not documented in info.  Switch
running_test_suite off for info-test, to hide it (and any future
TESTING commands) from info-test.

Suppress the command counter increment for TESTING commands, so they
can be used without upsetting pseudorandom numbers

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
Markus Armbruster 2014-01-13 21:27:16 +01:00
parent 73f1ac8a2c
commit e852d458f9
9 changed files with 126 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

58
src/lib/commands/testing.c Normal file
View file

@ -0,0 +1,58 @@
/*
* Empire - A multi-player, client/server Internet based war game.
* Copyright (C) 1986-2014, Dave Pare, Jeff Bailey, Thomas Ruschak,
* Ken Stevens, Steve McClure, Markus Armbruster
*
* Empire is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* ---
*
* See files README, COPYING and CREDITS in the root of the source
* tree for related information and legal notices. It is expected
* that future projects/authors will amend these files as needed.
*
* ---
*
* testing.c: Commands for test-suite use
*
* Known contributors to this file:
* Markus Armbruster, 2014
*/
#include <config.h>
#include "chance.h"
#include "commands.h"
#include "testing.h"
int
testing_cmd(void)
{
char *p;
char buf[1024];
p = getstarg(player->argp[1], "? ", buf);
if (!p)
return RET_SYN;
if (!strcmp(p, "added")) {
p = getstarg(player->argp[2], "number? ", buf);
test_suite_prng_seed -= strtol(p, NULL, 10);
p = getstarg(player->argp[3], "BTUs? ", buf);
player->btused -= strtol(p, NULL, 10);
p = getstarg(player->argp[4], "money? ", buf);
player->dolcost -= strtod(p, NULL);
return RET_OK;
}
return RET_SYN;
}