empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix struct loststr / struct empobj mismatch corrupting lostitems

Browse source 
The initial parts of struct loststr and struct empobj must match.
Commit 49780e2c screwed that up for members lost_uid/uid, which also
broke the equivalence of lost_owner/own.  Since lost_uid is not used,
the former had no effect.  But the latter broke xdvisible().  Could
make xdump lost leak information.

Commit a680c811 reorderd struct loststr members to make lost_timestamp
equivalent to new struct empobj member timestamp, but failed due to
the bug in commit 49780e2c.  Commit f33b96b1 then set the timestamp
through empobj, which screwed up timestamps in lostitems, i.e. it
broke incremental xdump lost.

All of the above is in v4.3.12.

Commit 536ef0b0 (v4.3.15) added lost_seqno / seqno.  No effect,
because only seqno is used.
This commit is contained in:
Markus Armbruster 2008-08-01 08:50:24 -04:00
parent e58be3179a
commit eb252201b6
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/lost.h
View file

@ -40,7 +40,7 @@
struct loststr { struct loststr {
/* initial part must match struct empobj */ /* initial part must match struct empobj */
short ef_type; short ef_type;
int lost_uid; short lost_uid;
unsigned lost_seqno; unsigned lost_seqno;
time_t lost_timestamp; /* When it was lost */ time_t lost_timestamp; /* When it was lost */
natid lost_owner; /* Who lost it */ natid lost_owner; /* Who lost it */