empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(coll, fina, repa, shark, disloan): Fix calculation of regular and

Browse source 
extended (beyond due date) loan time.  At the due date, or after a
last payment made at the due date, durations were zero in fina() and
unpredictable elsewhere.  With luck, debtors could abuse this to repay
loans cheap (they couldn't gain cash, though), sharks to purchase
loans cheap, and creditors to collect excessively.
This commit is contained in:
Markus Armbruster 2004-08-20 07:01:26 +00:00
parent ef0060ec57
commit fcbe36e76c
5 changed files with 54 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/lib/commands/fina.c
View file

@ -56,8 +56,6 @@ fina(void)
int xdur;
double rate;
double amt;
time_t due;
time_t last;
if (!opt_LOANS) {
pr("Loans are not enabled.\n");
@ -73,26 +71,19 @@ fina(void)
while (nxtitem(&ni, (s_char *)&loan)) {
if (loan.l_status != LS_SIGNED)
continue;
due = loan.l_duedate;
last = loan.l_lastpay;
rdur = 0;
xdur = 0;
if (now < due) {
rdur = now - last;
xdur = 0;
}
if (last < due && due < now) {
rdur = due - last;
xdur = now - due;
}
if (due < last) {
/*
* split duration now - l_lastpay into regular (up to l_duedate)
* and extended (beyond l_duedate)
*/
rdur = loan.l_duedate - loan.l_lastpay;
xdur = now - loan.l_duedate;
if (rdur < 0) {
xdur += rdur;
rdur = 0;
xdur = now - last;
}
if (loan.l_ldur == 0) {
logerror("loan #%d has zero duration", ni.cur);
if (CANT_HAPPEN(loan.l_ldur == 0))
continue;
}
rate = loan.l_irate / (loan.l_ldur * 8640000.0);
/* changed following to avoid overflow 3/27/89 bailey@math-cs.kent.edu