Commit graph

743 commits

Author SHA1 Message Date
45ad6a8e71 (rea): Simplify. 2006-04-30 08:38:06 +00:00
b812435762 (lowerit): Simplify. 2006-04-30 08:37:06 +00:00
935d9b736f (grin): Simplify. 2006-04-30 08:36:41 +00:00
37b18621bc (dist): Simplify. 2006-04-30 08:34:05 +00:00
db407ec065 (best): Rename local variable. 2006-04-30 08:32:50 +00:00
0c8c169f88 (s_char): Remove. Use signed char for small integers, plain char for
characters.
2006-04-29 16:25:17 +00:00
0a3a73cf3d Recent s_char purge changed element types to s_char *, but missed
patterns malloc(N * sizeof(s_char *)), fix.
2006-04-29 16:14:48 +00:00
4cf7389ecd (cede_sect): Remove dead code. 2006-04-29 15:28:30 +00:00
3e42c03405 (fly): Use void * for generic pointer dst_ptr. 2006-04-29 15:27:48 +00:00
78c502fe87 (vis, visbuf): Rev. 1.15 changed base type from s_char to char. This
is misleading, as the elements are numbers.  Change to signed char.
2006-04-29 15:19:57 +00:00
a988b907fc s_char purge directed by compiler warnings. 2006-04-29 06:41:45 +00:00
25fd374d53 Update known contributors comment. 2006-04-26 18:14:54 +00:00
071bf4da06 (xdvisible): Add case EF_REALM. Should have been added along with
EF_REALM (file.h rev. 1.52).  This made xdump leak everybody's realms.
2006-04-23 12:33:33 +00:00
Ron Koenderink
2e27313cee (map, sct, rout): Remove unused local variables. 2006-04-21 13:19:16 +00:00
6fee3f4535 (CANT_REACH): New. Use it instead of CANT_HAPPEN() where possible.
(oops): Cope with NULL argument passed by CANT_REACH().
2006-04-17 17:36:07 +00:00
8b1c21a7bd Trim superflous casts and parenthesis. 2006-04-17 08:24:12 +00:00
7598bf59d0 (noise): Drop second parameter, it is always true. 2006-04-17 08:16:48 +00:00
3813203174 (getin): Confusing. Redesign.
(edit): Simplify.

(doland): Spelling fix.
2006-04-17 08:13:20 +00:00
7b97f33789 (doplane): Don't arbitrarily truncate value for key 'a' and 'd'.
s_char purge.
2006-04-17 08:09:14 +00:00
4836f6c543 Fix long lines. No functional changes. 2006-04-16 17:20:33 +00:00
328c9af40a (sail): There is no qsail command, remove test for it. Test the
second argument only when the command is sail.  Before, `unsail 42 q'
showed the sailing path instead of clearing it.
2006-04-15 10:55:19 +00:00
abb9ae2338 (bestownedpath): Return NULL on long path instead of "?". Terminate
returned path with 'h'.  This makes BestShipPath() and BestAirPath()
more similar to BestLandPath().  Simplify callers.
2006-04-05 09:30:38 +00:00
7cc14a2c9a (tend): Fix rev. 1.20: used to send bulletin to last tendee's owner,
unless that's the player, regardless of success.  Send them for every
successful tend to a foreign ship.
2006-04-05 07:06:58 +00:00
e8b50af84e (mission): Silence compiler warning. 2006-03-29 19:40:42 +00:00
9646854705 (mission): Plug memory leak. s_char purge. 2006-03-29 19:40:22 +00:00
bd2673a6e4 Remove superflous casts. 2006-03-28 19:51:48 +00:00
a1ce7db238 (move_ground): Drop first parameter of map callback, it's not used.
Callers changed.  s_char purge.
2006-03-28 19:46:40 +00:00
06b669924a Type of gift()'s generic pointer parameter was fixed in the previous
revision of src/lib/commands/load.c, change callers.
2006-03-28 19:20:08 +00:00
8065fe84e4 (multifire): Retreat when helpless used RET_INJURED instead of
RET_HELPLESS.  Closes #1146364.
2006-03-28 06:22:48 +00:00
fce8b1aa38 (lost): Simplify code for argument default value. 2006-03-27 19:53:05 +00:00
3aea505aa7 Cosmetics. 2006-03-27 19:50:38 +00:00
523936cfef (map, rout, sct, surv): Remove special case for sects argument `*',
snxtsct() handles it just fine.
2006-03-27 19:45:08 +00:00
f99bc9298a (map): Simplify slightly. 2006-03-27 19:24:44 +00:00
1ddb87d235 (tran_map): Set player->argp[0]. Required since bmap() was merged
into map() ca. 1995.  Fixes 'm' at test's move_ground() prompt.
Simplify clearing player->argp[2].  Don't clear beyond that.
2006-03-27 19:10:40 +00:00
18bbcb2c9e (tran_map): Set player->argp[0]. Required since bmap() was merged
into map() ca. 1995.  Clear player->argp[2].  Required since map
acquired its second argument in the early 90s.  Fixes 'm' at
transport's move_ground() prompt.
2006-03-27 19:00:42 +00:00
707e1aad72 (explore_map, nav_map, move_map, fly_map): Don't use snxtsct(), it
obeys conditionals.  Use snxtsct_dist().  Closes #785447.  Only march
and test were actually broken, the other uses zapped conditionals.
(move_map, fly_map, nav_map, navi): Don't zap conditionals.
2006-03-27 18:20:25 +00:00
021a91a779 The previous revision is wrong, back it out. 2006-03-26 17:36:27 +00:00
82a3c0d0f5 The revision before the previous one is partially wrong, back out the
bad parts.
2006-03-26 17:34:58 +00:00
e438227011 The revision before the previous one is wrong, back it out. 2006-03-26 17:33:46 +00:00
5d6e8c0685 (retr, lretr, doship, dounit): Zero-terminate retreat paths. The last
character in the array must be zero already.  Closes #1225708.
2006-03-26 14:42:27 +00:00
2f08b52cef (shut): Fix misuse of logerror(): passed formatted string instead of
format string and arguments.  Correctness depends on formatted string
not containing '%', which is the case.
2006-03-26 13:59:47 +00:00
29faf70fa7 (show_sail): Fix misuse of pr(): passed formatted string instead of
format string and arguments.  Correctness depends on paths not
containing '%', which is correct, but not as robust as it could be.
2006-03-26 13:57:34 +00:00
4c6fb12377 Code formatting. No functional changes. 2006-03-26 13:52:23 +00:00
b0a5d11a3f (show_nuke_capab, show_ship_capab, show_plane_capab, show_land_capab)
(prxy, border, ac_encounter, look, budg): Fix misuse of pr() and PR():
passed formatted string instead of format string and arguments.
Correctness depends on argument values and tables not containing '%',
which is correct, but fragile.
2006-03-26 13:41:46 +00:00
65168f0d93 (comm_bomb, ship_bomb, land_bomb, pinflak_planedamage): Fix dangerous
misuse of pr(), PR() and mpr(): passed formatted string instead of
format string and arguments.  Crash bug if formatted string contains
'%'.  Players can put that in ship names...
2006-03-26 13:34:35 +00:00
ade364fa1d (prunits, prplanes): Simplify, compute relation string instead of
format.

(prplanes): Fix dangerous misuse of pr(): passed formatted string
instead of format string and arguments.  Crash bug if formatted string
contains '%'.  Players can put that in country names...
2006-03-26 12:54:52 +00:00
7b4a164d0a (prod): Simplify printing of materials used. Don't assume amount fits
into eight characters and item mnemo can't be '%'.
2006-03-26 12:37:22 +00:00
aee94ca077 (head_describe): Print the headline instead of returning the format
string.  This simplifies format string checking.
2006-03-26 12:08:35 +00:00
197d8cd2ca (prthresh): Remove format string parameter. Callers don't really need
that flexibility, and it makes format checking harder.
2006-03-26 10:21:57 +00:00
8cd3845b08 Remove useless multiplications with sizeof(char) and sizeof(s_char).
Replace by literal 1 in other contexts.
2006-03-26 10:16:08 +00:00